{AKS} az aks create/update: Outbound type should not be updated if it is not set#30539
Conversation
MartinForReal
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
microsoft-github-policy-service
bot
requested review from
FumingZhang and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
MartinForReal
changed the title
FumingZhang
reviewed
Dec 18, 2024
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Can you add a case to verify that the situation reported by the customer can now be properly handled? (update scenario, value of outbound type is not camel cased, should pass cli validation)
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
FumingZhang
reviewed
Dec 19, 2024
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
…hould be validaated
FumingZhang
approved these changes
Dec 23, 2024
yanzhudd
changed the title
az aks create/update: Outbound type should not be updated if it is not set
yanzhudd
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
{AKS}: _get_outbound_type should return None and natgateway profile hould be validaated
Testing Guide
History Notes
{AKS}
az aks create/update: Outbound type should not be updated if it is not setThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.