Skip to content

{core} aaz: Fix bug for int value to float value convert #30891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 1 commit into from
Feb 26, 2025
Merged

{core} aaz: Fix bug for int value to float value convert #30891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/azure-cli-core/azure/cli/core/aaz/_arg_action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@ def format_data(cls, data):
if isinstance(data, cls._schema.DataType):
return data

if isinstance(data, int) and cls._schema.DataType == float:
return data

raise AAZInvalidValueError(f"{cls._schema.DataType} type value expected, got '{data}'({type(data)})")


Expand Down
13 changes: 13 additions & 0 deletions src/azure-cli-core/azure/cli/core/tests/test_aaz_arg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1520,6 +1520,19 @@ def test_aaz_object_arg(self):
"new_i_pv6": '00:00:00'
})

# test assign the int value to the float field, it should be converted to float
action.setup_operations(dest_ops, ["{enable:True,tags:null,vnets:null,pt:12,newIPv6:'00:00:00'}"])
self.assertEqual(len(dest_ops._ops), 13)
dest_ops.apply(v, "properties")
self.assertEqual(v.properties, {
"enable": True,
"tags": None,
"vnets": None,
"pt": 12.0,
"new_i_pv6": '00:00:00'
})


def test_aaz_has_value_for_buildin(self):
from azure.cli.core.aaz import has_value, AAZUndefined
self.assertTrue(has_value(0))
Expand Down