[App Service] Fix #20983: az webapp config ssl import: Make web app a non-required parameter#30958
Merged
zhoxing-ms merged 11 commits intoAzure:devfrom Mar 26, 2025
Merged
[App Service] Fix #20983: az webapp config ssl import: Make web app a non-required parameter#30958zhoxing-ms merged 11 commits intoAzure:devfrom
az webapp config ssl import: Make web app a non-required parameter#30958zhoxing-ms merged 11 commits intoAzure:devfrom
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| functionapp config ssl import | cmd functionapp config ssl import update parameter name: removed property required=True |
||
| webapp config ssl import | cmd webapp config ssl import update parameter name: removed property required=True |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
seligj95
changed the title
az webapp config ssl import: make web app a non-required parameteraz webapp config ssl import: Make web app a non-required parameter
zhoxing-ms
previously approved these changes
Mar 24, 2025
seligj95
dismissed
zhoxing-ms’s stale review
The merge-base changed after approval.
zhoxing-ms
previously approved these changes
Mar 24, 2025
seligj95
dismissed
zhoxing-ms’s stale review
The merge-base changed after approval.
Contributor
@seligj95 Could you please pull the latest code from remote dev branch to pass the CI check? |
Contributor
|
please note that Azure CLI will have a code freeze on 03/25/2025 07:00 UTC for the upcoming release. If you want to catch this release train, please address the commands ASAP, otherwise it has to be postponed to next sprint (05-06). |
Contributor
Author
@zhoxing-ms I pulled in the latest |
Contributor
Author
|
@zhoxing-ms Looks like there is a test now failing due to something unrelated to my changes. Can you have a look? |
zhoxing-ms
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp config ssl import
Description
Fixes: #20983
Testing Guide
You no longer need to provide a web app for this command. Previously, it used the webapp's location as the location of the webspace for the cert import. Now, if a webapp is not provided, it takes the resource groups location instead.
az webapp config ssl import -g <> --key-vault <> --key-vault-certificate-name <>
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.