{AKS} az aks create: Add upcoming breaking change announcement#31056
Merged
{AKS} az aks create: Add upcoming breaking change announcement#31056
az aks create: Add upcoming breaking change announcement#31056Conversation
mbifeld
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @mbifeld, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
reviewed
Mar 18, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py:8:0: C0301: Line too long (157/120) (line-too-long)
src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py:9:0: C0301: Line too long (189/120) (line-too-long)
CLI Style failed with above error, please fix it
src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py
Outdated
Show resolved
Hide resolved
stl327
approved these changes
Mar 18, 2025
FumingZhang
approved these changes
Mar 18, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Mar 19, 2025
yanzhudd
changed the title
az aks create: Add upcoming breaking change announcement
ghost
mentioned this pull request
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks create
Description
This PR introduces an announcement for breaking changes in az aks create. The default value of --node-vm-size will be changing from 'Standard_DS2_V2 (Linux), Standard_DS2_V3 (Windows)' to being dynamically selected by the AKS resource provider based on quota and capacity.
Testing Guide
Behavior is not changed
This checklist is used to make sure that common guidelines for a pull request are followed.
[ x] The PR title and description has followed the guideline in Submitting Pull Requests.
[x ] I adhere to the Command Guidelines.
[ x] I adhere to the Error Handling Guidelines.