Skip to content

[ARO] az aro create: Update VM SKU to align with best practices #31074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 1 commit into from
Mar 21, 2025
Merged

[ARO] az aro create: Update VM SKU to align with best practices #31074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/azure-cli/azure/cli/command_modules/aro/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ def aro_create(cmd, # pylint: disable=too-many-locals
outbound_type='Loadbalancer',
disk_encryption_set=None,
master_encryption_at_host=False,
master_vm_size='Standard_D8s_v3',
master_vm_size='Standard_D8s_v5',
worker_encryption_at_host=False,
worker_vm_size='Standard_D4s_v3',
worker_vm_size='Standard_D4s_v5',
worker_vm_disk_size_gb='128',
worker_count='3',
apiserver_visibility='Public',
Expand Down Expand Up @@ -115,7 +115,7 @@ def aro_create(cmd, # pylint: disable=too-many-locals
if not rp_client_sp_id:
raise ResourceNotFoundError("RP service principal not found.")

worker_vm_size = worker_vm_size or 'Standard_D4s_v3'
worker_vm_size = worker_vm_size or 'Standard_D4s_v5'

if apiserver_visibility is not None:
apiserver_visibility = apiserver_visibility.capitalize()
Expand Down Expand Up @@ -152,7 +152,7 @@ def aro_create(cmd, # pylint: disable=too-many-locals
preconfigured_nsg='Enabled' if enable_preconfigured_nsg else 'Disabled',
),
master_profile=openshiftcluster.MasterProfile(
vm_size=master_vm_size or 'Standard_D8s_v3',
vm_size=master_vm_size or 'Standard_D8s_v5',
subnet_id=master_subnet,
encryption_at_host='Enabled' if master_encryption_at_host else 'Disabled',
disk_encryption_set_id=disk_encryption_set,
Expand Down
Loading