Do NOT Merge: [AKS] az aks update: Allow updating --bootstrap-container-registry-resource-id when --bootstrap-artifact-source is not provided#31120
Open
bingosummer wants to merge 1 commit intoAzure:devfrom
Conversation
bingosummer
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @bingosummer, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
bingosummer
changed the title
az aks update: allow updating only --bootstrap-container-registry-resource-idaz aks update: allow updating --bootstrap-container-registry-resource-id when --bootstrap-artifact-source is not provided
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
karataliu
approved these changes
Mar 25, 2025
bingosummer
changed the title
az aks update: allow updating --bootstrap-container-registry-resource-id when --bootstrap-artifact-source is not providedaz aks update: Allow updating --bootstrap-container-registry-resource-id when --bootstrap-artifact-source is not provided
…-resource-id` when `--bootstrap-artifact-source` is not provided
bingosummer
force-pushed
the
binxi/network-isolated-cluster-fix
branch
from
d909f88 to
986687f
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
bingosummer
changed the title
az aks update: Allow updating --bootstrap-container-registry-resource-id when --bootstrap-artifact-source is not providedaz aks update: Allow updating --bootstrap-container-registry-resource-id when --bootstrap-artifact-source is not provided
karataliu
suggested changes
Mar 25, 2025
Contributor
karataliu
left a comment
karataliu
left a comment
There was a problem hiding this comment.
verify in preivew cli firstly
FumingZhang
reviewed
Mar 26, 2025
| bootstrap_container_registry_resource_id = self.context.get_bootstrap_container_registry_resource_id() | ||
| if hasattr(mc, "bootstrap_profile") and bootstrap_artifact_source is not None: | ||
| if bootstrap_artifact_source != CONST_ARTIFACT_SOURCE_CACHE and bootstrap_container_registry_resource_id: | ||
| if hasattr(mc, "bootstrap_profile"): |
Member
There was a problem hiding this comment.
Please add a new or update an existing live test case to cover this scenario
yanzhudd
modified the milestones:
May 2025 (2025-05-06),
Build 2025 (2025-05-19)❗ Breaking change release ❗
zhoxing-ms
removed this from the
Build 2025 (2025-05-19)❗ Breaking change release ❗ milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks updateDescription
This PR is to fix the bug:
When the user runs
az aks update --bootstrap-container-registry-resource-id <new-acr-id>to update the container registry resource ID, the request is ignored since--bootstrap-artifact-sourceis not provided.The correct behavior is:
If the existing cluster's bootstrap profile artifact source is
Cache, updating only ACR ID should be allowed.If the existing cluster's bootstrap profile is empty or the artifact source is
Direct, updating only ACR ID should be disallowed.Testing Guide
History Notes
[AKS]
az aks update: Allow updating--bootstrap-container-registry-resource-idwhen--bootstrap-artifact-sourceis not providedThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.