{ACR} Migrate helm deprecation announcement #31194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| acr helm delete | cmd acr helm delete removed property deprecate_info_redirect |
||
| acr helm delete | cmd acr helm delete removed property deprecate_info_target |
||
| acr helm install-cli | cmd acr helm install-cli removed property deprecate_info_redirect |
||
| acr helm install-cli | cmd acr helm install-cli removed property deprecate_info_target |
||
| acr helm list | cmd acr helm list removed property deprecate_info_redirect |
||
| acr helm list | cmd acr helm list removed property deprecate_info_target |
||
| acr helm push | cmd acr helm push removed property deprecate_info_redirect |
||
| acr helm push | cmd acr helm push removed property deprecate_info_target |
||
| acr helm repo add | cmd acr helm repo add removed property deprecate_info_redirect |
||
| acr helm repo add | cmd acr helm repo add removed property deprecate_info_target |
||
| acr helm show | cmd acr helm show removed property deprecate_info_redirect |
||
| acr helm show | cmd acr helm show removed property deprecate_info_target |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
Member
Author
|
@renshao Please review and update the deprecation message to reflect the changes in the retirement schedule. |
renshao
approved these changes
Apr 4, 2025
Contributor
|
Looks good to me. Thanks for migrating the deprecation message to the new framework. |
zhoxing-ms
reviewed
Apr 7, 2025
src/azure-cli/azure/cli/command_modules/acr/_breaking_change.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Apr 7, 2025
src/azure-cli/azure/cli/command_modules/acr/_breaking_change.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Apr 7, 2025
src/azure-cli/azure/cli/command_modules/acr/_breaking_change.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Xing Zhou <[email protected]>
renshao
approved these changes
Apr 8, 2025
zhoxing-ms
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
acr helmDescription
Migrate the Helm deprecation announcement to the new announcement framework.
Previously, this announcement was manually added to the Upcoming Breaking Changes document. Now, it can be generated automatically through the framework.
Testing Guide
az acr helm -haz acr helm list -haz acr helm list -n qinkaitestnotexistedHistory Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.