[Backup] Add cli support for ASE backup operations by kumarutkarsh3b2166 · Pull Request #31269 · Azure/azure-cli

kumarutkarsh3b2166 · 2025-04-14T18:36:35Z

Related command

az backup container show
az backup container list
az backup item list
az backup item show
az backup policy list
az backup item set-policy
az backup container register
az backup container re-register
az backup container unregister

Description
This PR adds support for ASE workload operations for existing operations. This does not break any existing command and hence is not a breaking change.

Testing Guide
Added unit tests in tests_ase_commands.py

This checklist is used to make sure that common guidelines for a pull request are followed.

[*] The PR title and description has followed the guideline in Submitting Pull Requests.
[*] I adhere to the Command Guidelines.
[*] I adhere to the Error Handling Guidelines.

azure-client-tools-bot-prd · 2025-04-14T18:36:38Z

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

azure-client-tools-bot-prd · 2025-04-14T18:36:41Z

Hi @kumarutkarsh3b2166,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

azure-client-tools-bot-prd · 2025-04-14T18:36:44Z

Validation for Breaking Change Starting...

Thanks for your contribution!

yonzhan · 2025-04-14T18:36:50Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2025-04-14T18:36:52Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

microsoft-github-policy-service · 2025-04-14T18:37:15Z

Thank you for your contribution @kumarutkarsh3b2166! We will review the pull request and get back to you soon.

…31214) * Upgrading SQL * re-record the tests * record the tests * Fixing the last set of tests

* Bug fix * remove test that is not used anymore --------- Co-authored-by: Jingnan <jingnanxu@microsoft.com>

kumarutkarsh3b2166 · 2025-04-15T06:44:09Z

@kumarutkarsh3b2166 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.

Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.

Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.

Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree company="Microsoft"

kumarutkarsh3b2166 · 2025-04-15T06:44:45Z

@kumarutkarsh3b2166 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

zubairabid · 2025-04-15T07:46:27Z

src/azure-cli/azure/cli/command_modules/backup/custom_wl.py

                     'SAPHanaDatabase': 'SAPHanaDatabase',
-                     'SAPASE': 'SAPAseDatabase'}
+                     'SAPASE': 'SAPAseDatabase',
+                     'SAPAseDatabase': 'SAPAseDatabase'}


Do we need to add this to protectable_item_type_map as well? AFAIK SAPASE comes under the Azure Workload backup management type, so it would be required so that some operations (list protectable items, show protectable instance) don't fail.

zubairabid · 2025-04-15T07:47:52Z

src/azure-cli/azure/cli/command_modules/backup/custom_wl.py

+    if (not cust_help.is_sql(backup_item_type) and not
+        cust_help.is_hana(backup_item_type) and not
+            cust_help.is_sapase(backup_item_type)):
+        raise InvalidArgumentValueError("Item must be either of type SQLDataBase "


nit grammar: either-or is for two arguments. Use "Item must be of type SQLDataBase, SAPHanaDatabase, or SAPAseDatabase"

src/azure-cli/azure/cli/command_modules/backup/tests/latest/test_ase_commands.py

…ink is updated to Hyperscale tier (Azure#31344) * Print warning message during update slo to Hyperscale for a geo-replicated database * Auto generated test changes after running tests in record mode * Revert "Auto generated test changes after running tests in record mode" This reverts commit 9cec2ad. * Recorded tests * Update logic to return boolean instead of tuple and function name changes * Recorded tests

…c-zone-balancing to support setting automatic zone rebalancing policy (Azure#31377)

kumarutkarsh3b2166 added 7 commits April 14, 2025 15:20

support ase get ops

dfb6797

is sap check

3a64da9

support ase get ops

d2de35f

long line fix

f284859

flake8 failures resolved

dd58d71

unit tests

6375e75

fix

aace0e6

kumarutkarsh3b2166 requested review from jsntcy, yanzhudd and zhoxing-ms as code owners April 14, 2025 18:36

azure-client-tools-bot-prd bot added this to the Build 2025 (2025-05-19)❗ Breaking change release ❗ milestone Apr 14, 2025

microsoft-github-policy-service bot requested review from wangzelin007 and yonzhan April 14, 2025 18:37

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 14, 2025

microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Apr 14, 2025

microsoft-github-policy-service bot assigned zhoxing-ms Apr 14, 2025

microsoft-github-policy-service bot added the Backup label Apr 14, 2025

debalinaroy and others added 2 commits April 15, 2025 09:51

[SQL] Update azure-mgmt-sql Package from 4.0.0b20 to 4.0.0b21 (Azure#…

71a7ded

…31214) * Upgrading SQL * re-record the tests * record the tests * Fixing the last set of tests

{AFD} Fix bug for az afd rule action list (Azure#31260)

42850b4

* Bug fix * remove test that is not used anymore --------- Co-authored-by: Jingnan <jingnanxu@microsoft.com>

zubairabid reviewed Apr 15, 2025

View reviewed changes

src/azure-cli/azure/cli/command_modules/backup/tests/latest/test_ase_commands.py Show resolved Hide resolved

jiasli and others added 15 commits April 28, 2025 17:17

{Core} Bump MSAL to 1.32.3 (Azure#31376)

1696f9f

[Compute] az vmss create/update: Add new parameters --enable-automati…

9e76255

…c-zone-balancing to support setting automatic zone rebalancing policy (Azure#31377)

{Packaging} Unpin cffi in RPM package (Azure#31359)

97763e8

Merge pull request Azure#31378 from Azure/release

478da82

support ase get ops

90eb7cf

is sap check

a45c208

support ase get ops

3a50f5a

long line fix

9da3e2c

flake8 failures resolved

8c087df

unit tests

22d02e1

fix

73e848e

tests for backup restore added

8e9e68b

bkp res policy command tests added

9d71a27

resolve conflicts

afb3740

kumarutkarsh3b2166 requested review from AllyW, FumingZhang, Greedygre, Juliehzl, bebound, calvinhzy, digimaun, evelyn-ys, howang-ms, jiasli, kairu-ms and necusjz as code owners May 5, 2025 06:31

kumarutkarsh3b2166 added 2 commits May 6, 2025 16:05

seperate tests for conf prot and stop prot

946fdc7

comments updated

efeec61

kumarutkarsh3b2166 closed this May 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backup] Add cli support for ASE backup operations#31269

[Backup] Add cli support for ASE backup operations#31269
kumarutkarsh3b2166 wants to merge 86 commits intoAzure:devfrom
kumarutkarsh3b2166:users/kumarutkarsh/postops

kumarutkarsh3b2166 commented Apr 14, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Apr 14, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Apr 14, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Apr 14, 2025

Uh oh!

yonzhan commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

microsoft-github-policy-service bot commented Apr 14, 2025

Uh oh!

kumarutkarsh3b2166 commented Apr 15, 2025

Contribution License Agreement

Uh oh!

kumarutkarsh3b2166 commented Apr 15, 2025

Uh oh!

zubairabid Apr 15, 2025

Uh oh!

zubairabid Apr 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

kumarutkarsh3b2166 commented Apr 14, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Apr 14, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Apr 14, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Apr 14, 2025

Uh oh!

yonzhan commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

microsoft-github-policy-service bot commented Apr 14, 2025

Uh oh!

kumarutkarsh3b2166 commented Apr 15, 2025

Contribution License Agreement

Uh oh!

kumarutkarsh3b2166 commented Apr 15, 2025

Uh oh!

zubairabid Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

zubairabid Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants