{Auth} Add telemetry for enable_broker_on_wsl#31275
{Auth} Add telemetry for enable_broker_on_wsl#31275
enable_broker_on_wsl#31275Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Hi @jiasli, |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
||
| # On WSL, use core.enable_broker_on_wsl=true to use broker (WAM) | ||
| enable_broker_on_wsl = cli_ctx.config.getboolean('core', 'enable_broker_on_wsl', fallback=False) | ||
| set_broker_info(enable_broker_on_wsl) |
There was a problem hiding this comment.
set_broker_info(enable_broker_on_windows, enable_broker_on_wsl) expects both enable_broker_on_windows and enable_broker_on_wsl, but it’s currently called with a single positional argument. It might be clearer and safer to pass both values in a single call (or use keyword arguments) to avoid misconfiguration.
Related command
Description
Add telemetry for
enable_broker_on_wsl(#31169).Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.