[Compute] az vm create/update: Add new parameters --wire-server-mode --wire-server-access-control-profile-reference-id to support setting wireserver endpoint settings#31279
Merged
zhoxing-ms merged 2 commits intoAzure:devfrom Apr 18, 2025
Conversation
Jing-song
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
Build 2025 (2025-05-19)❗ Breaking change release ❗ milestone
|
Hi @Jing-song, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm create | cmd vm create added parameter imds_access_control_profile_reference_id |
||
| vm create | cmd vm create added parameter imds_mode |
||
| vm create | cmd vm create added parameter key_incarnation_id |
||
| vm create | cmd vm create added parameter wire_server_access_control_profile_reference_id |
||
| vm create | cmd vm create added parameter wire_server_mode |
||
| vm create | cmd vm create update parameter proxy_agent_mode: added property deprecate_info_redirect=--wire-server-mode |
||
| vm create | cmd vm create update parameter proxy_agent_mode: added property deprecate_info_target=--proxy-agent-mode |
||
| vm update | cmd vm update added parameter imds_access_control_profile_reference_id |
||
| vm update | cmd vm update added parameter imds_mode |
||
| vm update | cmd vm update added parameter key_incarnation_id |
||
| vm update | cmd vm update added parameter wire_server_access_control_profile_reference_id |
||
| vm update | cmd vm update added parameter wire_server_mode |
||
| vm update | cmd vm update update parameter proxy_agent_mode: added property deprecate_info_redirect=--wire-server-mode |
||
| vm update | cmd vm update update parameter proxy_agent_mode: added property deprecate_info_target=--proxy-agent-mode |
||
| vmss create | cmd vmss create added parameter imds_access_control_profile_reference_id |
||
| vmss create | cmd vmss create added parameter imds_mode |
||
| vmss create | cmd vmss create added parameter wire_server_access_control_profile_reference_id |
||
| vmss create | cmd vmss create added parameter wire_server_mode |
||
| vmss create | cmd vmss create update parameter proxy_agent_mode: added property deprecate_info_redirect=--wire-server-mode |
||
| vmss create | cmd vmss create update parameter proxy_agent_mode: added property deprecate_info_target=--proxy-agent-mode |
||
| vmss update | cmd vmss update added parameter imds_access_control_profile_reference_id |
||
| vmss update | cmd vmss update added parameter imds_mode |
||
| vmss update | cmd vmss update added parameter wire_server_access_control_profile_reference_id |
||
| vmss update | cmd vmss update added parameter wire_server_mode |
||
| vmss update | cmd vmss update update parameter proxy_agent_mode: added property deprecate_info_redirect=--wire-server-mode |
||
| vmss update | cmd vmss update update parameter proxy_agent_mode: added property deprecate_info_target=--proxy-agent-mode |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
zhoxing-ms
reviewed
Apr 16, 2025
| ]) | ||
|
|
||
| self.cmd('vmss create -g {rg} -n {vmss1} --image ubuntu2204 --enable-proxy-agent --proxy-agent-mode Audit --vm-sku Standard_D2s_v3 --orchestration-mode Flexible', checks=[ | ||
| self.cmd('vmss create -g {rg} -n {vmss1} --image Win2022Datacenter --nsg {nsg} --enable-proxy-agent --wire-server-mode Audit --imds-mode Audit --vm-sku Standard_D2s_v3 --orchestration-mode Flexible --admin-password Password001!', checks=[ |
Contributor
There was a problem hiding this comment.
May I ask why do we need to replace the test image?
Contributor
Author
There was a problem hiding this comment.
These new parameters are not available for ubuntu2204 ，so replaced it with Win2022Datacenter
zhoxing-ms
reviewed
Apr 16, 2025
Comment on lines
1715
to
1717
| if enable_proxy_agent is not None or wire_server_mode is not None or imds_mode is not None or \ | ||
| wire_server_access_control_profile_reference_id is not None or \ | ||
| imds_access_control_profile_reference_id is not None or key_incarnation_id is not None: |
Contributor
There was a problem hiding this comment.
This judgment condition seems too complex. Is there any way to simplify it or make it more readable?
zhoxing-ms
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm create/updateaz vmss create/updateDescription
VM/VMSS to support v2 Version of Azure Metadata Security Protocol
close #29279
Testing Guide
History Notes
[Compute]
az vm create/update: Add new parameters--wire-server-modeand--wire-server-access-control-profile-reference-idto support setting wireserver endpoint settings[Compute]
az vmss create/update: Add new parameters--wire-server-modeand--wire-server-access-control-profile-reference-idto support setting wireserver endpoint settings[Compute]
az vm create/update: Add new parameters--imds-modeand--imds-access-control-profile-reference-idto support setting IMDS endpoint settings[Compute]
az vmss create/update: Add new parameters--imds-modeand--imds-access-control-profile-reference-idto support setting IMDS endpoint settings[Compute]
az vm create/update: Add new parameter--key-incarnation-idto support setting key incarnation id[Compute]
az vmss create/update: Add new parameter--key-incarnation-idto support setting key incarnation idThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.