Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
Build 2025 (2025-05-19)❗ Breaking change release ❗ milestone
|
Hi @AllyW, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Pan-Qi,
bebound,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
Contributor
Author
|
An example for GH task execution time:
An example for ADO task execution time:
Time taken for |
wangzelin007
approved these changes
Apr 17, 2025
jiasli
reviewed
Apr 22, 2025
| merge_base=$(git merge-base HEAD "$base_branch_pre"/"$base_branch") | ||
| echo merge_base: "$merge_base" | ||
| # check azdev style on diff mod | ||
| azdev style |
Member
There was a problem hiding this comment.
How is azdev style on diff mode without specifying these arguments?
Git Arguments
--repo : Path to the Git repo to check.
--src : Name of the Git source branch to check (i.e. master or upstream/master).
--tgt : Name of the Git target branch to check (i.e. dev or upstream/dev).
Contributor
Author
There was a problem hiding this comment.
For now azdev style runs in full mode, to be consistent with ado pipeline: https://github.com/Azure/azure-cli/blob/dev/azure-pipelines.yml#L1055
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Add
azdev style & lintertask into github workflow, with no dependency on token or pr write permission.Test pr: AllyW#2
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.