Skip to content

[AKS] az aks create/update az aks nodepool add: Add static egress gateway feature support#31285

Merged
yanzhudd merged 8 commits intoAzure:devfrom
moreOver0:add_sgc
Jun 23, 2025
Merged

[AKS] az aks create/update az aks nodepool add: Add static egress gateway feature support#31285
yanzhudd merged 8 commits intoAzure:devfrom
moreOver0:add_sgc

Conversation

@moreOver0
Copy link
Contributor

@moreOver0 moreOver0 commented Apr 16, 2025

Related command

az aks create/update
az aks nodepool add

Description

Add static egress gateway related change from preview. Adding flags & validation to below commands

  • az aks create/update
  • az aks nodepool add

Azure CLI extension PR: Azure/azure-cli-extensions#7527

Testing Guide

az aks create <CLUSTER_NAME> --enable-static-egress-gateway
az aks update <CLUSTER_NAME> --enable-static-egress-gateway
az aks update <CLUSTER_NAME> --disable-static-egress-gateway
az aks nodepool add <NODEPOOL_NAME> --mode Gateway --gateway-prefix-size 31

History Notes

[AKS] az aks create: Add --enable-static-egress-gateway parameter to support static egress gateway feature
[AKS] az aks update: Add --enable-static-egress-gateway parameter to support static egress gateway feature
[AKS] az aks nodepool add: Add option Gateway to --mode parameter and --gateway-prefix-size parameter to support static egress gateway feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Apr 16, 2025

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.9
️✔️acs
️✔️latest
️✔️3.12
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.9
️✔️ams
️✔️latest
️✔️3.12
️✔️3.9
️✔️apim
️✔️latest
️✔️3.12
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️aro
️✔️latest
️✔️3.12
️✔️3.9
️✔️backup
️✔️latest
️✔️3.12
️✔️3.9
️✔️batch
️✔️latest
️✔️3.12
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.9
️✔️billing
️✔️latest
️✔️3.12
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.9
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.9
️✔️config
️✔️latest
️✔️3.12
️✔️3.9
️✔️configure
️✔️latest
️✔️3.12
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.9
️✔️container
️✔️latest
️✔️3.12
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.9
️✔️core
️✔️latest
️✔️3.12
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.9
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.9
️✔️dls
️✔️latest
️✔️3.12
️✔️3.9
️✔️dms
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.9
️✔️find
️✔️latest
️✔️3.12
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.9
️✔️identity
️✔️latest
️✔️3.12
️✔️3.9
️✔️iot
️✔️latest
️✔️3.12
️✔️3.9
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.9
️✔️lab
️✔️latest
️✔️3.12
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️maps
️✔️latest
️✔️3.12
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.9
️✔️network
️✔️latest
️✔️3.12
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.9
️✔️profile
️✔️latest
️✔️3.12
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.9
️✔️redis
️✔️latest
️✔️3.12
️✔️3.9
️✔️relay
️✔️latest
️✔️3.12
️✔️3.9
️✔️resource
️✔️latest
️✔️3.12
️✔️3.9
️✔️role
️✔️latest
️✔️3.12
️✔️3.9
️✔️search
️✔️latest
️✔️3.12
️✔️3.9
️✔️security
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.9
️✔️sql
️✔️latest
️✔️3.12
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.9
️✔️storage
️✔️latest
️✔️3.12
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.9
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.9
️✔️util
️✔️latest
️✔️3.12
️✔️3.9
️✔️vm
️✔️latest
️✔️3.12
️✔️3.9

@azure-client-tools-bot-prd
Copy link

Hi @moreOver0,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Apr 16, 2025

❌AzureCLI-BreakingChangeTest
❌acs
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_static_egress_gateway
⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter gateway_prefix_size
⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter mode: updated property choices from ['System', 'User'] to ['Gateway', 'System', 'User']
⚠️ 1010 - ParaPropUpdate aks nodepool update cmd aks nodepool update update parameter mode: updated property choices from ['System', 'User'] to ['Gateway', 'System', 'User']
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_static_egress_gateway
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_static_egress_gateway

Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:

  • Breaking changes can only be merged during the designated breaking change window
  • A pre-announcement must be released at least one month in advance

For more details on how to introduce breaking changes, refer to the documentation: azure-cli/doc/how_to_introduce_breaking_changes.md

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 16, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS az aks/acs/openshift labels Apr 16, 2025
@moreOver0 moreOver0 changed the title [AKS] az aks create/update az aks nodepool add: add static egress gateway related change [AKS] az aks create/update az aks nodepool add: add static egress gateway feature support Apr 16, 2025
@moreOver0
Copy link
Contributor Author

This PR depends on AKS api version v20250401

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_and_agentpool_with_static_egress_gateway

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@zhoxing-ms
Copy link
Contributor

Please resolve these CI issues and conflicts

@FumingZhang
Copy link
Member

updated milestone to https://github.com/Azure/azure-cli/milestone/157

@moreOver0
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 31285 in repo Azure/azure-cli

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 12, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@moreOver0
Copy link
Contributor Author

moreOver0 commented Jun 12, 2025

current validation failure depends on dependency bump from azure-mgmt-containerservice~=36.0.0 to
azure-mgmt-containerservice~=37.0.0

@FumingZhang
Copy link
Member

current validation failure depends on dependency bump from azure-mgmt-containerservice~=36.0.0 to azure-mgmt-containerservice~=37.0.0

bumping the SDK and default API version in #31649, while the PR is currently blocked by windows package build CI, cli team is investigating

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_and_agentpool_with_static_egress_gateway

@AKSCustomResourceGroupPreparer(
random_name_length=17, name_prefix="clitest", location="westus2"
)
def test_aks_and_agentpool_with_static_egress_gateway(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the corresponding recording file to pass the CI checks. You could generate one by running the test in live mode.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recording added

@zhoxing-ms zhoxing-ms changed the title [AKS] az aks create/update az aks nodepool add: add static egress gateway feature support [AKS] az aks create/update az aks nodepool add: Add static egress gateway feature support Jun 23, 2025
@zhoxing-ms
Copy link
Contributor

@FumingZhang Could you please review this PR in a timely manner? Please note that Azure CLI will have a code freeze on 06/24/2025 07:00 UTC for the upcoming release. If you want to catch this release train, please resolve the CI issue ASAP, otherwise it has to be postponed to next sprint (08-05).

@yanzhudd yanzhudd merged commit bbefc97 into Azure:dev Jun 23, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants