[AKS] az aks create/approuting: Add default NIC config for app routing#31286
Merged
[AKS] az aks create/approuting: Add default NIC config for app routing#31286
az aks create/approuting: Add default NIC config for app routing#31286Conversation
jaiveerk
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
Build 2025 (2025-05-19)❗ Breaking change release ❗ milestone
|
Hi @jaiveerk, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks approuting enable | cmd aks approuting enable added parameter nginx |
||
| aks approuting update | cmd aks approuting update added parameter nginx |
||
| aks create | cmd aks create added parameter app_routing_default_nginx_controller |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
Author
|
@yanzhudd @zhoxing-ms would it be possible to get a review on this to make it in time for the current milestone? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jaiveerk
changed the title
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jaiveerk
changed the title
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
lgtm, queued live test days ago, test passed!
|
Contributor
Author
Looks like live tests passed! What's the next step here? |
Contributor
Author
|
@yanzhudd @zhoxing-ms just bumping this for review, thanks! |
biefy
reviewed
May 1, 2025
biefy
approved these changes
May 1, 2025
Member
|
@jaiveerk, it is a public holiday in China from May 1st to May 5th. After the holiday, the CLI team member will review and merge the PR. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
az aks create/approuting: Add default NIC config for app routing
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks createaz aks approutingDescription
Adds functionality to allow users to specify the default nginx ingress controller type on the app routing add-on. Sets the ingressProfile.webAppRouting.nginx.defaultIngressControllerType field via the az aks create command (via the paramter --app-routing-default-nginx-controller) as well as the az aks approuting command (via the parameter --nginx).
Testing Guide
az aks create .... --app-routing-default-nginx-controller={external|internal|none|annotationcontrolled}az aks approuting enable --nginx={external|internal|none|annotationcontrolled}az aks approuting update --nginx={external|internal|none|annotationcontrolled}History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.