[AKS] Add feature support for apiserver vnet integration#31318
Merged
[AKS] Add feature support for apiserver vnet integration#31318
Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
Build 2025 (2025-05-19)❗ Breaking change release ❗ milestone
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter apiserver_subnet_id |
||
| aks create | cmd aks create added parameter enable_apiserver_vnet_integration |
||
| aks update | cmd aks update added parameter apiserver_subnet_id |
||
| aks update | cmd aks update added parameter disable_private_cluster |
||
| aks update | cmd aks update added parameter enable_apiserver_vnet_integration |
||
| aks update | cmd aks update added parameter enable_private_cluster |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
FumingZhang,
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Auto-Assign
levimm
changed the title
feiskyer
approved these changes
Apr 28, 2025
Collaborator
|
Please fix CI issues |
Contributor
Author
|
all CI failure is I don't think it's related to my change. |
Member
|
Queued live test to validate the change, test passed!
|
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
added 5 commits
May 1, 2025 11:02
Contributor
Author
|
now the failure is related to appservice module, not acs. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
approved these changes
May 2, 2025
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31318 in repo Azure/azure-cli |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
updated the history notes: |
yanzhudd
approved these changes
May 7, 2025
4 tasks
This was referenced Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks create --enable-apiserver-vnet-integration
az aks update --enable-apiserver-vnet-integration --apiserver-subnet-id
az aks update --enable-private-cluster
az aks update --disable-private-cluster
Description
GA the feature for apiserver vnet integration. Support create/update with
--enable-apiserver-vnet-integration. Also support update cluster to enable or disable private cluster with apiserver vnet integration is used.Most logic are copied from AKS cli extension.
Testing Guide
az aks create --enable-apiserver-vnet-integration
az aks update --enable-apiserver-vnet-integration --apiserver-subnet-id
az aks update --enable-private-cluster
az aks update --disable-private-cluster
History Notes
[AKS]
az aks create/update: Add support for apiserver vnet integration featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.