{Role} Clean up linter exclusion rules#31323
Merged
Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
Build 2025 (2025-05-19)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
jiasli
requested review from
bebound,
jsntcy,
kairu-ms and
zhoxing-ms
as code owners
bebound
approved these changes
Apr 24, 2025
zhoxing-ms
reviewed
Apr 24, 2025
| with self.argument_context('ad user') as c: | ||
| c.ignore('_subscription') | ||
| c.argument('mail_nickname', help='mail alias. Defaults to user principal name') | ||
| c.argument('force_change_password_next_login', arg_type=get_three_state_flag(), help='Require the user to change their password the next time they log in. Only valid when --password is specified') |
Contributor
There was a problem hiding this comment.
May I ask removing this parameter looks like a breaking change, right? If so, why not indicate it in the PR title?
Member
Author
There was a problem hiding this comment.
Good question! force_change_password_next_login has been renamed to force_change_password_next_sign_in (#22432). force_change_password_next_sign_in is no longer used.
zhoxing-ms
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az roleaz adDescription
Clean up linter exclusion rules.