Add optional parameter --assignee-principal-type to az aks update --attach-acr#31461
Closed
Add optional parameter --assignee-principal-type to az aks update --attach-acr#31461
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Hi @jovieir, |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks update --attach-acrDescription
This commit introduces a new parameter,
--assignee-principal-type,to theaz aks update --attach-acrcommand in the Azure CLI, allowing users to explicitly specify the principal type (e.g., User, Group, or ServicePrincipal) for ACR role assignment. This enhancement aims to address Role-Based Access Control (RBAC)-related errors by ensuring the correct principal type is applied during the ACR role assignment, specifically when using Azure RBAC role assignment conditionsThe original
--attach-acrparameter omits the principalType from the requestBody, which causes the authorization request to be invalidated when used with role assignment conditions.The original logic is not changed, as to not break existing implementation. The optional parameter, when used, overrides the default behavior to ensure the correct principal type is applied during the ACR role assignment.
Testing Guide
( ( !(ActionMatches{'Microsoft.Authorization/roleAssignments/write'}) ) OR ( @Request[Microsoft.Authorization/roleAssignments:PrincipalType] ForAnyOfAnyValues:StringEqualsIgnoreCase {'ServicePrincipal', 'Group'}) )az aks update -g <rg> -n <cluster_name> --attach-acr <acr name>and notice the 403 Unauthorized exception from ARM.--assignee-principal-typeand the expected principalType and the command succeeds.History Notes
[Azure CLI] Add optional parameter --assignee-principal-type to az aks update --attach-acr
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.