[DMS] az dms project create: Change location parameter to be optional#31465
Merged
[DMS] az dms project create: Change location parameter to be optional#31465
az dms project create: Change location parameter to be optional#31465Conversation
️✔️AzureCLI-FullTest
|
|
Hi @temandr, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
temandr
changed the title
az dms (project) create now don't require the location parameter and correcting help inputs az dms (project) create now don't require the location parameter and correcting help inputs
…om:temandr/azure-cli into users/arpavlic/update-help_remove-location
sergb213
suggested changes
May 15, 2025
temandr
changed the title
az dms (project) create now don't require the location parameter and correcting help inputsaz dms project create now doesn't require the location parameter and correcting help inputs
sergb213
approved these changes
May 16, 2025
| examples: | ||
| - name: Create an instance of DMS. | ||
| text: > | ||
| az dms create -l westus -n mydms -g myresourcegroup --sku-name Basic_2vCores --subnet /subscriptions/{vnetSubscriptionId}/resourceGroups/{vnetResourceGroup}/providers/Microsoft.Network/virtualNetworks/{vnetName}/subnets/{subnetName} --tags tagName1=tagValue1 tagWithNoValue |
Contributor
There was a problem hiding this comment.
Should we mention above that this parameter is available, although it is optional and it defaults to the resource group location? Since resource groups have global scope, someone may wish to create "MySQL migrations" resource group and add a few DMS services in multiple regions, for example. And it is not clear how this could be done from the help.
evelyn-ys
changed the title
az dms project create now doesn't require the location parameter and correcting help inputsaz dms project create: Change location parameter to be optional
kairu-ms
previously approved these changes
Jun 23, 2025
3 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Azure CLI DMS (Database Migration Service) module to make the location parameter optional for the az dms project create command and the az dms create command. The changes enable automatic location detection from the associated DMS service or resource group instead of requiring explicit location specification.
- Make location parameter optional for project creation by deriving it from the DMS service
- Make location parameter optional for service creation by defaulting to resource group location
- Update test cases to remove explicit location parameters from command invocations
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test_service_scenarios.py | Updated test commands to remove explicit location parameters |
| custom.py | Added location auto-detection logic and made location optional in service/project creation functions |
| _help.py | Updated help documentation examples to remove location parameter usage |
| _client_factory.py | Added resource groups client factory function for location retrieval |
Collaborator
|
Please fix CI issues |
sergb213
approved these changes
Aug 12, 2025
yonzhan
modified the milestones:
September 2025 (2025-09-02),
October 2025 (2025-10-14)
kairu-ms
modified the milestones:
October 2025 (2025-10-14),
November 2025 (2025-11-18)❗ Breaking change release ❗
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
necusjz
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az dms project create ...
az dms create ...
Description
_helpfile to reflect more accurate inputs for the MySQL connection input and for thebinlog_info.az dms project create ...command and using the service to gather that information.Testing Guide
Re-ran tests with live input and adhoc tested
az dms create ...andaz dms project create ...This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.