[ACR] remove check for _utils (DO NOT MERGE)#31477
Closed
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| acr connected-registry create | cmd acr connected-registry create removed property is_preview |
||
| acr connected-registry deactivate | cmd acr connected-registry deactivate removed property is_preview |
||
| acr connected-registry delete | cmd acr connected-registry delete removed property is_preview |
||
| acr connected-registry get-settings | cmd acr connected-registry get-settings removed property is_preview |
||
| acr connected-registry list | cmd acr connected-registry list removed property is_preview |
||
| acr connected-registry list-client-tokens | cmd acr connected-registry list-client-tokens removed property is_preview |
||
| acr connected-registry permissions show | cmd acr connected-registry permissions show removed property is_preview |
||
| acr connected-registry permissions update | cmd acr connected-registry permissions update removed property is_preview |
||
| acr connected-registry repo | cmd acr connected-registry repo removed property is_preview |
||
| acr connected-registry show | cmd acr connected-registry show removed property is_preview |
||
| acr connected-registry update | cmd acr connected-registry update removed property is_preview |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
JXavierMSFT,
northtyphoon,
rosanch,
shizhMSFT,
terencet-dev,
toddysm,
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Auto-Assign
…isavo-msft/azure-cli into test-for-containerregistry
msyyc
changed the title
_utils (DO NOT MERGE)_utils (DO NOT MERGE)
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31477 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jiasli
reviewed
May 22, 2025
| g.command('rotate-key', "rotate_key") | ||
|
|
||
| with self.command_group('acr connected-registry', acr_connected_registry_util, is_preview=True) as g: | ||
| with self.command_group('acr connected-registry', acr_connected_registry_util) as g: |
Contributor
There was a problem hiding this comment.
Good catch, please do not add any unrelated logic to this PR, thanks. @msyyc
Then maybe we can modify this title from [ACR] to {ACR}, because this is not perceived by customers
Contributor
There was a problem hiding this comment.
This change should be merged by this PR https://github.com/Azure/azure-cli/pull/31475/files
Contributor
|
Please resolve these conflicts |
Contributor
|
please note that Azure CLI will have a code freeze on 05/27/2025 07:00 UTC for the upcoming release. Please address these conflicts ASAP, otherwise it has to be postponed to next sprint (07-01). |
3 tasks
Contributor
|
This PR will be replaced by #31555 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Remove private preview message for az acr connected-registry
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature