{dls} Update python adls gen1 sdk version to 1.0.1#31599
Merged
{dls} Update python adls gen1 sdk version to 1.0.1#31599
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Data Lake Store SDK version from 1.0.0a0 to 1.0.1 and adjusts related test recordings accordingly. Key changes include:
- Bumped the dependency version for azure-datalake-store in setup.py and all platform-specific requirements files.
- Updated test parameters (e.g. location from "westus2" to "centraluseuap") and modified recorded interactions to reflect new CLI and SDK versions.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updated dependency version for azure-datalake-store |
| src/azure-cli/requirements.py3.{windows,Linux,Darwin}.txt | Updated dependency version for azure-datalake-store on all platforms |
| src/azure-cli/azure/cli/command_modules/dls/tests/latest/test_dls_commands.py | Updated test parameters including location and added new firewall update parameter |
| src/azure-cli/azure/cli/command_modules/dls/tests/latest/recordings/*.yaml | Updated test recordings to reflect changed API responses, regions, and version strings |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/dls/tests/latest/test_dls_commands.py:366
- The firewall update command now includes the '--start-ip-address' parameter. Please ensure that this change is fully supported by the underlying API and that corresponding documentation and help texts are updated accordingly.
self.cmd('dls account firewall update -g {rg} -n {dls} --firewall-rule-name {fw} --start-ip-address {start_ip} --end-ip-address {new_end_ip}')
evelyn-ys
approved these changes
Jun 10, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
@akharit azure-datalake-store 1.0.1 does not provide source dist on pypi and homebrew build fails. |
Member
Author
|
@bebound Uploaded. Can you check? |
Contributor
It works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az dls *
Description
Addresses #31469
Testing Guide
azdev test dls --live
Updated recordings.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.