[ACR] az acr connected-registry create: Fix for enabling dedicated endpoint on container registry resource when user confirms during creation#31661
Merged
zhoxing-ms merged 5 commits intoAzure:devfrom Jun 20, 2025
Conversation
joshbaunach
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @joshbaunach, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
JXavierMSFT,
northtyphoon,
rosanch,
shizhMSFT,
terencet-dev,
toddysm and
yonzhan
joshbaunach
requested review from
huanwu and
trisavo-msft
and removed request for
JXavierMSFT,
northtyphoon,
shizhMSFT,
terencet-dev,
toddysm and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that when creating a connected registry with a user-confirmed dedicated data endpoint, the Azure Container Registry is actually updated via API.
- Added a test covering the case where the dedicated endpoint is not initially enabled.
- Modified
acr_connected_registry_createto call the ACR REST API (acr_update_set) after user confirmation. - Updated imports to bring in
cf_acr_registriesandacr_update_setfor the new API call.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test_acr_connectedregistry_commands.py | Added test_acr_connectedregistry_dedicated_endpoint_not_enabled to verify endpoint enabling behavior |
| connected_registry.py | Called cf_acr_registries and acr_update_set to persist the dataEndpointEnabled update |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/acr/connected_registry.py:79
- Verify that
acr_update_customno longer requiresresource_group_nameas its parameter; if its signature still expects(cmd, registry, resource_group_name, ...), this call will fail at runtime.
acr_update_custom(cmd, registry, data_endpoint_enabled=True)
src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_connectedregistry_commands.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
changed the title
az acr connected-registry create: Enable dedicated endpoint on container registry resource when user confirms during az acr connected-registry create
Contributor
|
Please note that 'history notes' here refers to the content that needs to be written into CLI release notes for this PR change, rather than any related historical PR content |
joshbaunach
changed the title
az acr connected-registry create: Enable dedicated endpoint on container registry resource when user confirms during az acr connected-registry createaz acr connected-registry create: Fix for enabling dedicated endpoint on container registry resource when user confirms during az acr connected-registry create
Contributor
Author
|
@zhoxing-ms Thanks for the clarification on the History Notes section. A bit of clarification regarding the title: this PR is a bugfix for the error where the command would fail if the user replied "y" to the dedicated endpoint prompt; the prompt itself was added in #28807. I updated the title to clarify that this PR is a bugfix, but feel free to update the title again if needed. |
zhoxing-ms
changed the title
az acr connected-registry create: Fix for enabling dedicated endpoint on container registry resource when user confirms during az acr connected-registry createaz acr connected-registry create: Fix for enabling dedicated endpoint on container registry resource when user confirms during creation
zhoxing-ms
approved these changes
Jun 20, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az acr connected-registry create
Description
In #28807, the behavior of
az acr connected-registry createwas modified. If the user does not have dedicated data endpoint enabled for their ACR, then the command would ask whether they want to enable it before creating the Connected Registry. However, there is a glitch. The ACR resource would only be modified in-memory, meaning that dedicated endpoint would remain disabled on the actual ACR.This PR ensures an API request to modify the ACR is made when the user wants to enable dedicated endpoint on their ACR while creating a Connected Registry.
Testing Guide
az acr create -n [your name] -g [your rg] --sku premiumaz acr connected-registry create -n [your choice of connected registry name] --registry [your ACR name] --repository hello-worldy.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.