{Storage}: Add None version for ResourceType.DATA_STORAGE_TABLE #31670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requires it in extension
️✔️AzureCLI-FullTest
|
|
Hi @calvinhzy, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
calvinhzy
requested review from
bebound,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a “None” API version for the DATA_STORAGE_TABLE resource type so that calling get_sdk will succeed for this resource.
- Introduces
ResourceType.DATA_STORAGE_TABLE: Nonein the default API version mapping - Ensures extensions relying on
get_sdkcan handle table storage
Comments suppressed due to low confidence (2)
src/azure-cli-core/azure/cli/core/profiles/_shared.py:221
- Add a unit test that verifies
default_api_version(ResourceType.DATA_STORAGE_TABLE)returnsNone, ensuring this new mapping is covered by automated tests.
ResourceType.DATA_STORAGE_TABLE: None,
src/azure-cli-core/azure/cli/core/profiles/_shared.py:221
- [nitpick] Consider updating the
default_api_versiondocstring or adding an inline comment to clarify whyDATA_STORAGE_TABLEis set toNonefor maintainability.
ResourceType.DATA_STORAGE_TABLE: None,
evelyn-ys
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Add None version for ResourceType.DATA_STORAGE_TABLE as using get_sdk requires it in extension for Azure/azure-cli-extensions#8878
The reason that the value is None is because get_sdk() by default will search for parent folder with the version number unless this specific value of None is provided, and the DATA_STORAGE_TABLE package is single-api, therefore having no parent folder with a version number.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.