{CI} Speed up CLI linter and style checks with multicore agents#31688
Merged
{CI} Speed up CLI linter and style checks with multicore agents#31688
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @bebound, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Pan-Qi,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR speeds up the execution of the CLI linter and style checks by switching from a single-core pool (ubuntu_pool) to a multi-core pool (ubuntu_multi_core_pool) for improved performance.
- Replaces the pool used for the "Check CLI Style" job
- Replaces the pool used for the "Check CLI Linter" job
bebound
changed the title
jiasli
reviewed
Jun 23, 2025
| timeoutInMinutes: 120 | ||
| pool: | ||
| name: ${{ variables.ubuntu_pool }} | ||
| name: ${{ variables.ubuntu_multi_core_pool }} |
Member
There was a problem hiding this comment.
Why is the multi-core agent pool not used before?
Contributor
Author
There was a problem hiding this comment.
The multicore agent was initially created specifically for running rpm/deb tests, as they exceed the 2 hours timeout, and did not consider being used for azdev style.
jiasli
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use multicore agent for these tests to speed up the CI. The ultimate solution is using
ruff.Ref:
https://dev.azure.com/azclitools/public/_build/results?buildId=254153&view=logs&jobId=168ccbe3-da49-5c0b-6478-08f7016e4bf5&j=36dd4138-4d53-5e46-00d9-e5cd9744be05
https://dev.azure.com/azclitools/public/_build/results?buildId=254279&view=logs&j=168ccbe3-da49-5c0b-6478-08f7016e4bf5