{AKS} az aks upgrade: Fix recording test for AKS upgrade with tier switch#31695
Merged
zhoxing-ms merged 1 commit intoAzure:devfrom Jun 26, 2025
Merged
{AKS} az aks upgrade: Fix recording test for AKS upgrade with tier switch#31695zhoxing-ms merged 1 commit intoAzure:devfrom
az aks upgrade: Fix recording test for AKS upgrade with tier switch#31695zhoxing-ms merged 1 commit intoAzure:devfrom
Conversation
wenxuan0923
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @wenxuan0923, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors version-selection helpers and updates the AKS upgrade test to use the latest non-LTS and closest lower LTS versions, adding existence checks and a minor-version-difference guard.
- Replaced
_get_newer_non_lts_versionwith three focused methods:_get_latest_non_lts_version,_get_lower_lts_version, and_get_minor_version. - Updated
test_aks_upgrade_with_tier_switchto skip when appropriate versions aren’t found or when the minor-version gap exceeds 3.
Comments suppressed due to low confidence (3)
FumingZhang
reviewed
Jun 24, 2025
Member
There was a problem hiding this comment.
Queued live test to validate the change, test passed!
- test_aks_upgrade_with_tier_switch
FumingZhang
approved these changes
Jun 26, 2025
zhoxing-ms
changed the title
az aks upgrade: Fix recording test for AKS upgrade with tier switchaz aks upgrade: Fix recording test for AKS upgrade with tier switch
zhoxing-ms
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
fix recording test
Description
When this test was originally added, we had an LTS version every three minor Kubernetes releases. The test was designed to upgrade a cluster from an LTS version to the next minor (non-LTS) version. However, we recently changed our policy to make every Kubernetes version an LTS version. This change introduced a large minor version gap between the previously non-LTS and LTS versions, causing the test to fail.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.