Skip to content

Initial commit - update api version to 2025-06-05, remove is_preview …#31716

Closed
Elina-L wants to merge 2 commits intoAzure:devfrom
Elina-L:wenxliu/SpotPlacementScoreGA20250605
Closed

Initial commit - update api version to 2025-06-05, remove is_preview …#31716
Elina-L wants to merge 2 commits intoAzure:devfrom
Elina-L:wenxliu/SpotPlacementScoreGA20250605

Conversation

@Elina-L
Copy link
Member

@Elina-L Elina-L commented Jun 25, 2025

…flags

Related command

az compute-recommender spot-placement-recommender

Description

Change the azure cli spot-placement-recommender command status from preview to GA API version 2025-06-05

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI review requested due to automatic review settings June 25, 2025 21:43
@azure-client-tools-bot-prd
Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

This comment was marked as outdated.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 25, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@Elina-L Elina-L requested a review from Copilot July 15, 2025 20:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the spot-placement-recommender command from preview to GA by removing preview flags and bumping the API version to 2025-06-05.

  • Removed all is_preview=True flags from the command registration and argument definitions
  • Updated _aaz_info version strings and the api-version query parameter to "2025-06-05"

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/azure-cli/azure/cli/command_modules/compute_recommender/aaz/latest/compute_recommender/_spot_placement_recommender.py Removed preview flags and updated API version lines
src/azure-cli/azure/cli/command_modules/compute_recommender/aaz/latest/compute_recommender/__cmd_group.py Removed preview flag from command group registration
Comments suppressed due to low confidence (2)

src/azure-cli/azure/cli/command_modules/compute_recommender/aaz/latest/compute_recommender/_spot_placement_recommender.py:154

  • No tests have been updated to cover the new GA API version; please add or update unit tests to verify requests using 2025-06-05.
                    "api-version", "2025-06-05",

src/azure-cli/azure/cli/command_modules/compute_recommender/aaz/latest/compute_recommender/_spot_placement_recommender.py:25

  • [nitpick] The API version string is duplicated in multiple places; consider defining it as a shared constant to reduce duplication and simplify future updates.
        "version": "2025-06-05",

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Jul 28, 2025

Since the az compute-recommender spot-placement-recommender command is about to be deprecated, I believe this PR should no longer be needed, so I will close it first @Elina-L

@zhoxing-ms zhoxing-ms closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants