Skip to content

{HDInsight} new api version 2025-01-15-preview#31730

Closed
2258093686 wants to merge 17 commits intoAzure:devfrom
2258093686:hdi-cli-sdk-2025-01-15
Closed

{HDInsight} new api version 2025-01-15-preview#31730
2258093686 wants to merge 17 commits intoAzure:devfrom
2258093686:hdi-cli-sdk-2025-01-15

Conversation

@2258093686
Copy link
Member

@2258093686 2258093686 commented Jun 27, 2025

Related command

az hdinsight create
az hdinsight credentials update
az hdinsight credentials show

Description

  • Update API version to 2025-01-15-preview.
  • Add parameters --entra-user-identity and --entra-user-full-info to az hdinsight create to support creating Entra-enabled clusters.
  • Add support for creating clusters with WASB + MSI (Managed Identity) authentication in az hdinsight create.
  • Add two new commands to update/get cluster credentials.

Testing Guide

  1. create entra cluster by --entra-user-identity
az hdinsight create {other params}  --entra-user-identity "00000000-0000-0000-0000-000000000000" "test@example.com"  
  1. create entra cluster by --entra-user-full-info
az hdinsight create {other params}  --entra-user-full-info @path/EntraUserFullInfoConfig.json
  1. create cluster with WASB + MSI authentication
az hdinsight create {other params} --storage-account-name mystorageaccount --storage-account-managed-identity MyMSI
  1. update entra cluster's entra user
az hdinsight credentials update -g  -n {cluster} --resource-group {rg} --entra-user-identity "00000000-0000-0000-0000-000000000000" "test@example.com"  
  1. show current cluster credentials
az hdinsight credentials show -g  -n {cluster} --resource-group {rg} 

History Notes

[HDInsight] az hdinsight create: Support creating Entra-enabled clusters and creating clusters with WASB + MSI
[HDInsight] az hdinsight credentials update: Update cluster credentials.
[HDInsight] az hdinsight credentials show: Show current cluster credentials.


This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI review requested due to automatic review settings June 27, 2025 07:40
@2258093686 2258093686 requested a review from kairu-ms as a code owner June 27, 2025 07:40
@azure-client-tools-bot-prd
Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@2258093686 2258093686 marked this pull request as draft June 27, 2025 07:40
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 27, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

This comment was marked as outdated.

@yonzhan yonzhan requested a review from jsntcy June 27, 2025 08:13
@2258093686 2258093686 requested a review from Copilot July 21, 2025 06:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure HDInsight CLI commands to support the new API version 2025-01-15-preview, adding support for Entra-enabled cluster creation and new credential management commands.

  • Updates SDK version from 9.0.0b3 to 9.1.0b2 across all platform requirement files
  • Adds support for creating Entra-enabled clusters using --entra-user-identity and --entra-user-full-info parameters
  • Introduces new credential management commands for updating and viewing cluster credentials
  • Implements WASB + MSI authentication support for cluster creation

Reviewed Changes

Copilot reviewed 12 out of 37 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
setup.py & requirements.*.txt Updates HDInsight SDK dependency to version 9.1.0b2
util.py Adds utilities for WASB storage detection and Entra user information processing
custom.py Implements Entra authentication and credential update functionality
commands.py Registers new credential management commands
_params.py Adds parameter definitions for Entra user authentication
_help.py Provides documentation and examples for new features
test files Updates test cases to support new functionality and API changes

@2258093686 2258093686 requested a review from Copilot July 21, 2025 07:44

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot July 21, 2025 07:45

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot July 21, 2025 08:21

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot July 21, 2025 08:26

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot July 21, 2025 09:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the HDInsight API version to 2025-01-15-preview and adds support for creating Entra-enabled clusters and WASB + MSI authentication. The changes include updates to az hdinsight create with new parameters for Entra user configuration, support for WASB storage with managed identity authentication, and two new commands for cluster credential management.

  • Updates azure-mgmt-hdinsight package version and API version across multiple requirement files
  • Adds new Entra user identity parameters (--entra-user-identity and --entra-user-full-info) to hdinsight create command
  • Introduces new credential management commands (az hdinsight credentials update/show) for updating cluster credentials
  • Adds support for WASB + MSI authentication in cluster creation

Reviewed Changes

Copilot reviewed 12 out of 37 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
setup.py Updates azure-mgmt-hdinsight package version from 9.0.0b3 to 9.1.0b2
requirements.py3.*.txt Updates azure-mgmt-hdinsight package version across Windows, Linux, and Darwin requirement files
util.py Adds utility functions for WASB storage account detection and Entra user information handling
custom.py Modifies cluster creation logic to support Entra authentication and WASB+MSI, adds new credential update function
commands.py Registers new hdinsight credentials commands (show/update)
_params.py Adds new parameters for Entra user identity configuration in create and credentials update commands
_help.py Adds help documentation and examples for new Entra user features and credential management
test_hdinsight_commands.py Updates test configuration and adds new test cases for WASB+MSI and Entra user functionality
test_hdinsight_usage.yaml Updates test recordings to reflect new API version response format
entrauserconfig.json Adds test configuration file for Entra user full info parameter testing
Comments suppressed due to low confidence (1)

src/azure-cli/azure/cli/command_modules/hdinsight/util.py:360

  • [nitpick] The nested function name 'is_email' follows snake_case convention correctly but could be more descriptive. Consider 'contains_email_pattern' since it only checks for '@' and '.' characters.
    def is_email(value):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants