Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jsntcy,
kairu-ms and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the WAF custom-rule commands to support two new group-by variables (GeoLocationXffHeader and ClientAddrXffHeader) and bumps the API version to 2024-10-01 across relevant modules and recordings. It also refines schema flags to require certain properties.
- Add new enum values for XFF header support and mark
valuesas required in create/update - Bump
api-versionfrom2024-03-01to2024-10-01in AAZ command modules and recordings - Extend tests with a ClientAddrXffHeader scenario
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/latest/test_network_commands.py | Added test for ClientAddrXffHeader in --group-by-user-session |
aaz/latest/.../custom_rule/_create.py & _update.py |
Extended variable-name enum and set values flags to required |
aaz/latest/.../custom_rule/_show.py/_list.py/_delete.py |
Updated AAZ info version and resource paths to 2024-10-01 |
| tests/latest/recordings/test_network_app_gateway_waf_*.yaml (multiple files) | Updated recorded api-version to 2024-10-01 |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py:2629
- The value "ClientAddrXffHeader" uses lowercase "Xff", but the new enum is "ClientAddrXFFHeader". Please update the casing to match the enum definition.
'--group-by-user-session [{{group-by-variables:[{{variable-name:"ClientAddrXffHeader"}}]}}] '
necusjz
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network application-gateway waf-policy custom-rule create/delete/list/show/updateDescription
resolve #30954
Azure/aaz#805
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.