{Eventhub/Servicebus} Remove azure-mgmt-Eventhub azure-mgmt-servicebus multiapi references#31804
Merged
{Eventhub/Servicebus} Remove azure-mgmt-Eventhub azure-mgmt-servicebus multiapi references#31804
azure-mgmt-Eventhub azure-mgmt-servicebus multiapi references#31804Conversation
schaudhari6254888
requested review from
bebound,
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes multi-API references for Event Hubs and Service Bus by updating dependency versions, removing API gating in parameters, and clearing default API versions.
- Bump azure-mgmt-eventhub from 10.1.0 to 11.2.0 in setup and requirements.
- Drop
min_apiconstraints in Event Hubs CLI parameter contexts. - Set default API versions for Service Bus and Event Hubs to
Nonein core profiles.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updated azure-mgmt-eventhub version to ~=11.2.0. |
| src/azure-cli/requirements.py3.windows.txt (and Linux, Darwin) | Aligned azure-mgmt-eventhub version bumps across all platforms. |
| src/azure-cli/azure/cli/command_modules/eventhubs/_params.py | Removed min_api filters from namespace and create contexts. |
| src/azure-cli-core/azure/cli/core/profiles/_shared.py | Cleared default API versions for MGMT_SERVICEBUS and MGMT_EVENTHUB. |
Comments suppressed due to low confidence (5)
src/azure-cli/setup.py:86
- Ensure that Event Hubs command tests cover compatibility with the updated
azure-mgmt-eventhub11.2.0 API or add new tests for any breaking changes.
'azure-mgmt-eventhub~=11.2.0',
src/azure-cli-core/azure/cli/core/profiles/_shared.py:222
- Consider updating the module’s documentation or HISTORY.rst to explain why the default API version for Service Bus has been cleared.
ResourceType.MGMT_SERVICEBUS: None,
src/azure-cli-core/azure/cli/core/profiles/_shared.py:223
- Add a note in HISTORY.rst or inline comments to clarify the removal of the default API version for Event Hubs.
ResourceType.MGMT_EVENTHUB: None,
src/azure-cli/azure/cli/command_modules/eventhubs/_params.py:31
- Removing the
min_apifilter may expose parameters to API versions where they aren't supported; confirm that these arguments are valid across all versions or restore version gating.
with self.argument_context('eventhubs namespace' ) as c:
src/azure-cli/azure/cli/command_modules/eventhubs/_params.py:61
- Dropping the
min_apiconstraint here may apply parameters to unsupported API versions; verify compatibility or reintroduce the version check.
with self.argument_context('eventhubs namespace create') as c:
evelyn-ys
previously approved these changes
Jul 15, 2025
msyyc
suggested changes
Jul 15, 2025
Member
msyyc
left a comment
msyyc
left a comment
There was a problem hiding this comment.
azure-mgmt-eventhub==11.2.0 and azure-mgmt-servicebus==9.0.0 is actually not singleapi package. And SDK team will try to release singleapi version for these 2 packages soon.
Member
Author
Changed to latest API version |
msyyc
approved these changes
Jul 16, 2025
evelyn-ys
approved these changes
Jul 16, 2025
jsntcy
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.