Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| mysql flexible-server create | cmd mysql flexible-server create update parameter storage_redundancy: added property default=LocalRedundancy |
||
| mysql flexible-server replica create | cmd mysql flexible-server replica create update parameter storage_redundancy: added property default=LocalRedundancy |
||
| mysql flexible-server update | cmd mysql flexible-server update added parameter backup_interval |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
jsntcy,
wangzelin007,
yonzhan and
zhoxing-ms
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the MySQL flexible-server commands by changing the default storage redundancy to LocalRedundancy and adding a new --backup-interval parameter to the update command.
- Default
--storage-redundancyis now set toLocalRedundancyfor both create and update. - Introduces
--backup-intervalonaz mysql flexible-server updateand wires it through to the SDK and instance object. - Removes custom storage redundancy validation and helper in favor of the new default.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/mysql/custom.py | Removed manual storage_redundancy logic/validator, added backup_interval to update flow |
| src/azure-cli/azure/cli/command_modules/mysql/_validators.py | Dropped storage_redundancy_validator definition and calls |
| src/azure-cli/azure/cli/command_modules/mysql/_params.py | Set default for storage_redundancy to LocalRedundancy and added backup_interval CLI argument |
Comments suppressed due to low confidence (4)
src/azure-cli/azure/cli/command_modules/mysql/custom.py:379
- The
storage_redundancyargument was removed from the create call, so any user-provided value will be ignored. Reintroduce passingstorage_redundancy(defaulting to LocalRedundancy) into the SDK model.
accelerated_logs=accelerated_logs,
src/azure-cli/azure/cli/command_modules/mysql/custom.py:1049
- There are no existing tests covering the new
backup_intervalassignment. Consider adding unit tests to verify thatbackup_interval_hoursis set appropriately when provided.
if backup_interval:
src/azure-cli/azure/cli/command_modules/mysql/_params.py:482
- [nitpick] The new
backup_intervalargument needs a help string describing its purpose and valid range so users understand how to use it.
c.argument('backup_interval', arg_type=backup_interval_arg_type)
src/azure-cli/azure/cli/command_modules/mysql/custom.py:1026
- The update call now accepts
backup_intervalbut no longer accepts or setsstorage_redundancy. This will break any custom redundancy settings. Addstorage_redundancy=storage_redundancyback into the update payload.
iops=iops,
honghr
changed the title
az mysql flexible-server create/update: update --storage-redundancy parameter and --backup-intervalaz mysql flexible-server create/update: update --storage-redundancy parameter and --backup-interval
evelyn-ys
approved these changes
Jul 16, 2025
evelyn-ys
changed the title
az mysql flexible-server create/update: update --storage-redundancy parameter and --backup-intervalaz mysql flexible-server create/update: Update --storage-redundancy parameter and add --backup-interval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az mysql flexible-server create --storage-redundancy
az mysql flexible-server replica create --storage-redundancy
az mysql flexible-server update --backup-interval
Description
Add new parameter --backup-interval to server update command. And update --storage-redundancy default value to LocalRedundancy.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.