Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Service Fabric
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the az sf cluster create command incorrectly assumed the cluster name equals the resource group name when using custom templates. The fix ensures the cluster name is properly read from the parameters file when provided.
- Extracts cluster name from parameters file instead of assuming it equals resource group name
- Improves error message clarity for template deployment requirements
- Updates function call to use explicit keyword arguments for better readability
a-santamaria
approved these changes
Jul 16, 2025
zhoxing-ms
changed the title
az sf cluster create: Change behavior to read cluster_name from parameters file if provided to fix issue #5180az sf cluster create: Change behavior to read cluster_name from parameters file if provided
Contributor
|
Could you please add some test cases for these PR changes? |
Contributor
|
Please note that Azure CLI will freeze the code on 07/29/2025 07:00 UTC for the upcoming release. If you want to catch this release train, please resolve these comments ASAP, otherwise this PR has to be postponed to next sprint. |
zhoxing-ms
modified the milestones:
August 2025 (2025-08-05),
September 2025 (2025-09-02)
Member
Author
Test coverage for this would rely on the details for an existing certificate and passwords within a parameters file uploaded to the test repo, which seems inadvisable. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az sf cluster createDescription
Fixes #5180 where at the end of a deployment using a template, the client attempts to poll for the cluster status at end of creation with assumption that
--cluster_name==--resource_group_nameif--cluster-nameis not provided. Changed code to read--cluster_nameparameter from parameter file.History Notes
{Service Fabric}
az sf cluster create: Change behavior to read cluster_name from parameters file if provided to fix issue #5180This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.