[AKS] az aks update: Support VMAS to VMS agent pool migration in AKS commands#31831
Merged
[AKS] az aks update: Support VMAS to VMS agent pool migration in AKS commands#31831
az aks update: Support VMAS to VMS agent pool migration in AKS commands#31831Conversation
reneeli123
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update added parameter migrate_vmas_to_vms |
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for migrating an AKS cluster’s VMAS (Availability Set) agent pool to VMS (Virtual Machine Scale Sets) via the --migrate-vmas-to-vms flag in az aks update.
- Introduce the new
--migrate-vmas-to-vmsparameter, context getter, and help text. - Implement
update_vmas_to_vmsin the managed cluster decorator and wire it into the update pipeline. - Add unit and live tests for various migration scenarios.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/.../test_managed_cluster_decorator.py | Added test_update_vmas_to_vms and imported constants and CLIError. |
| src/.../test_aks_commands.py | Added a live test test_aks_migrate_vmas_to_vms. |
| src/.../managed_cluster_decorator.py | Imported new constants, added _get_outbound_type guard, implemented update_vmas_to_vms, and hooked it into update_mc_profile_default. |
| src/.../custom.py | Added migrate_vmas_to_vms parameter to aks_update. |
| src/.../_params.py | Registered migrate_vmas_to_vms argument. |
| src/.../_help.py | Added help entry for --migrate-vmas-to-vms. |
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
reneeli123
force-pushed
the
reneel/vmas-migration-ga
branch
from
aba379b to
322a482
Compare
reneeli123
changed the title
az aks: Support VMAS to VMS agent pool migration in AKS commandsaz aks update: Support VMAS to VMS agent pool migration in AKS commands
reneeli123
commented
Jul 17, 2025
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
FumingZhang
reviewed
Jul 18, 2025
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
Member
|
Live test passed! |
FumingZhang
previously approved these changes
Jul 18, 2025
zhoxing-ms
reviewed
Jul 18, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
…aks_commands.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
FumingZhang
approved these changes
Jul 21, 2025
yanzhudd
approved these changes
Jul 22, 2025
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks update --migrate-vmas-to-vms
Description
Migrate from Availability Sets in Azure Kubernetes Service (AKS)
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.