{Compute} az vm create: Fix API version when fetching virtual network resource#31868
Closed
{Compute} az vm create: Fix API version when fetching virtual network resource#31868
az vm create: Fix API version when fetching virtual network resource#31868Conversation
yanzhudd
requested review from
jsntcy,
wangzelin007 and
zhoxing-ms
as code owners
❌AzureCLI-FullTest
|
|
Hi @yanzhudd, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an API version compatibility issue in the az vm create command when fetching virtual network resources. The resource SDK package upgrade introduced a newer API version (2025-01-01) that is not yet supported by the server side.
- Replaces dynamic API version resolution with a hardcoded version from the network module
- Uses the VirtualNetworkShow command's API version instead of relying on the resource SDK
Contributor
|
Actually, I need to clarify that, in fact, the _resolve_api_version() method does not use the api-version defined by the resource SDK, but it defaults to using the latest stable api-version responded by the corresponding RP provider. azure-cli/src/azure-cli/azure/cli/command_modules/resource/custom.py Lines 4573 to 4595 in 13a94a6 So this ICM is actually caused by the Network RP provider exposing the currently unsupported api-version 2024-10-01 in advance, it should be a service issue, the Network service team needs to help investigate the root cause of this ICM. You can try running az rest --method get --url /subscriptions/<subscription_id>/providers/Microsoft.Network?api-version=2024-11-01 to reproduce this issue.
|
Contributor
|
Due to the customer current need for a temporary solution to quickly unblock their business, this PR need to be restored to provide a private package |
Contributor
Author
However, I’d like to clarify that this issue only occurs when using the resource SDK to fetch the latest API of Network, rather than using the Network SDK package or code-generated clients directly. |
3 tasks
Contributor
Author
|
replaced by #31945 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm createDescription
IcM: 656299018
In
az vm createcommand, we rely on the resource SDK package to determine which API version is used when fetching a virtual network resource from the backend. However, the resource package was upgraded in #31449. And the new API version being used is 2025-01-01 which is not yet supported by server side.The error message is:
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.