{Misc.} Remove unreachable code for creating SSL context#31919
Merged
{Misc.} Remove unreachable code for creating SSL context#31919
Conversation
jiasli
requested review from
FumingZhang,
bebound,
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unreachable code that handled SSL context creation for older Python versions and Windows Cloud Shell environments. Since Azure CLI now requires Python 3.9+ and Windows Cloud Shell doesn't exist, the conditional branches checking for Python < 3.4 and Windows Cloud Shell are no longer needed.
- Removes conditional logic for Python version checks (< 3.4) and Windows Cloud Shell detection
- Simplifies SSL context creation by directly using
ssl.create_default_context() - Cleans up duplicate
_ssl_context()function implementations across multiple modules
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/appservice/custom.py | Removes unreachable SSL context fallback code |
| src/azure-cli/azure/cli/command_modules/acs/custom.py | Removes unreachable SSL context fallback code |
| src/azure-cli/azure/cli/command_modules/acr/helm.py | Removes unreachable SSL context fallback code and unused sys import |
| src/azure-cli-core/azure/cli/core/util.py | Removes unreachable SSL context fallback code |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/acr/helm.py:368
- The
import sysstatement is no longer needed since the sys.version_info check was removed. This unused import should be deleted.
def _ssl_context():
yonzhan
approved these changes
Aug 6, 2025
zhoxing-ms
approved these changes
Aug 8, 2025
Contributor
|
ACR: @trisavo-msft App Service: @kumaramit-msft Could you please help review this PR? |
bebound
approved these changes
Aug 8, 2025
kumaramit-msft
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Azure CLI now only supports Python 3.9+:
azure-cli/src/azure-cli-core/setup.py
Line 85 in d7e8a34
and there is no Windows Cloud Shell, so this piece of code will never be hit.
For code cleanness, this PR removes the unreachable code.