Conversation
…recontainerstorage
nearora-msft
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @nearora-msft, |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in validation error messages for the Azure Container Storage disable functionality in the AKS module. The error message incorrectly referenced the --enable-azure-container-storage parameter when it should reference --disable-azure-container-storage.
- Fixed typo in error message to correctly reference the disable parameter instead of enable parameter
- Updated both the validator implementation and corresponding test case
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/azurecontainerstorage/_validators.py | Fixed error message to reference correct parameter name |
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_validators.py | Updated test case to match corrected error message |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
croomes
approved these changes
Aug 22, 2025
FumingZhang
approved these changes
Aug 23, 2025
yanzhudd
changed the title
az aks update: Fix typo on validation error for disabling azurecontainerstorageaz aks update: Fix typo on validation error for disabling Azure Container Storage
yanzhudd
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks update
Description
Fixes a typo in the validation errors
Testing Guide
az aks update --disable-azure-container-storage all
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.