[MySQL] az mysql flexible-server upgrade: Add new version 8.4#31998
Merged
[MySQL] az mysql flexible-server upgrade: Add new version 8.4#31998
az mysql flexible-server upgrade: Add new version 8.4#31998Conversation
️✔️AzureCLI-FullTest
|
|
Hi @honghr, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| mysql flexible-server upgrade | cmd mysql flexible-server upgrade update parameter version: updated property choices from ['8'] to ['8', '8.4'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for MySQL version 8.4 to the az mysql flexible-server upgrade command. Previously, only version 8 was supported for upgrades.
- Added version 8.4 as a valid upgrade option in the command parameters
- Updated version comparison logic to handle minor version numbers (8.4 vs 8.0)
- Enhanced replica server version validation to support the new version format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
_params.py |
Added '8.4' to the allowed version enum for the upgrade command |
custom.py |
Updated version mapping and comparison logic to handle major.minor version format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
evelyn-ys
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az mysql flexible-server upgrade --version
Description
Add new version option 8.4 to upgrade command
Testing Guide
az mysql flexible-server upgrade --version 8.4
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.