Conversation
nearora-msft
requested review from
FumingZhang,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a minor issue in the AKS create command where the --enable-azure-container-storage option would fail when the VM SKU was an empty string instead of None.
- Adds validation to check for empty string in addition to None when validating VM size for Azure Container Storage
- Prevents command failure when vm_sku is empty but not None
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
nearora-msft
changed the title
az aks create: Fix minor issue with --enable-azure-container-storage <pooltype> --container-storage-version 1
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
previously approved these changes
Sep 15, 2025
zhoxing-ms
changed the title
az aks create: Fix minor issue with --enable-azure-container-storage <pooltype> --container-storage-version 1az aks create: Fix minor issue on "az aks create --enable-azure-container-storage --container-storage-version 1" to not fail when VM SKU was empty
Contributor
|
Could you add some tests for this case? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
changed the title
az aks create: Fix minor issue on "az aks create --enable-azure-container-storage --container-storage-version 1" to not fail when VM SKU was emptyaz aks create: Fix the issue where enabling v1 container storage does not fail if the VM SKU field is left empty
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks create
Description
This PR makes minor fixes on "az aks create --enable-azure-container-storage --container-storage-version 1" to not fail when vm_sku was empty.
Testing Guide
az aks create -g test-rg -n test-cluster --enable-azure-container-storage azureDisk --container-storage-version 1
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.