[Service Connector]az aks connection show: update kubernetesResourceName in aks connection#32126
Closed
[Service Connector]az aks connection show: update kubernetesResourceName in aks connection#32126
az aks connection show: update kubernetesResourceName in aks connection#32126Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the return format of the get_aks_resource_name function from returning a list of resource names to returning a dictionary with descriptive keys for AKS connection resources.
- Changes return format from list to dictionary with 'secret' and 'serviceAccount' keys
- Improves code readability by providing explicit naming for returned resource types
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+569
to
+570
| return {'secret': secret_name, 'serviceAccount': service_account_name} | ||
| return {'secret': secret_name} |
There was a problem hiding this comment.
This change breaks the API contract by changing the return type from list to dictionary. This is a breaking change that could cause issues for existing code that expects a list. Consider adding version compatibility or deprecation warnings if this change is intentional.
Suggested change
| return {'secret': secret_name, 'serviceAccount': service_account_name} | |
| return {'secret': secret_name} | |
| return [secret_name, service_account_name] | |
| return [secret_name] |
microsoft-github-policy-service
bot
requested review from
FumingZhang,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Auto-Assign
xfz11
changed the title
az aks connection show: update kubernetesResourceName in aks connectionaz aks connection show: update kubernetesResourceName in aks connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.