[Compute] Fix #31929: Fix az vm/vmss update cannot update --wire-server-profile-id and --imds-profile-id#32129
Merged
zhoxing-ms merged 2 commits intoAzure:devfrom Sep 17, 2025
Merged
Conversation
Jing-song
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where az vm update and az vmss update commands could not update the --wire-server-profile-id and --imds-profile-id parameters. The fix implements a patch API approach to properly support updating these in-VM access control profile reference IDs.
- Adds a new patch-based update mechanism for profile reference IDs using AAZ classes
- Removes error-raising test assertions that were preventing these parameters from being updated
- Updates test configuration to use proper VM SKU for flexible orchestration mode
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Implements patch API for updating profile reference IDs in both VM and VMSS update functions |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Removes HttpResponseError assertions and adds comprehensive test for profile reference ID updates |
Comments suppressed due to low confidence (3)
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py:1
- Variable name 'wireseriver_prifile' contains a typo. It should be 'wireserver_profile' or similar.
# --------------------------------------------------------------------------------------------
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py:1
- Variable name 'imds_prifile' contains a typo. It should be 'imds_profile' or similar.
# --------------------------------------------------------------------------------------------
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py:1
- The variable name 'wireseriver_prifile' is inconsistent with the dictionary key 'wireserver_profileid'. Consider using consistent naming like 'wireserver_profile' for the variable.
# --------------------------------------------------------------------------------------------
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zhoxing-ms
changed the title
az vm/vmss update cannot update --wire-server-profile-id and --imds-profile-idaz vm/vmss update cannot update --wire-server-profile-id and --imds-profile-id
zhoxing-ms
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm/vmss updateDescription
Add patch api to support update inVMAccessControlProfileReferenceId
close #31929
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.