[Compute] az vm availability-set update: Add new parameter --enable-all-instance-down to support setting scheduled events profile#32285
Merged
zhoxing-ms merged 4 commits intoAzure:devfrom Oct 27, 2025
Conversation
Jing-song
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi @Jing-song, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm availability-set convert | cmd vm availability-set convert added parameter enable_all_instance_down |
||
| vm availability-set convert | cmd vm availability-set convert added parameter scheduled_events_api_version |
||
| vm availability-set update | cmd vm availability-set update added parameter enable_all_instance_down |
||
| vm availability-set update | cmd vm availability-set update added parameter scheduled_events_api_version |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for configuring Availability Set Scheduled Events policy via new parameters and updates API version references to 2025-04-01.
- Introduces parameters to auto-approve when all instances are down and to set scheduled events API version.
- Expands read/list schemas with new scheduled events fields and system data, plus version bump across CRUD commands.
- Adds tests and recordings for new parameters, though negative-only coverage for scheduled events API version.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test_vm_commands.py | Adds test for new parameters (--enable-all-instance-down and --scheduled-events-api-version) including negative scenario. |
| test_vm_avset_scheduled_events_policy_parameters.yaml | Recording for new test validating allInstancesDown and failed scheduledEventsApiVersion request. |
| test_vm_availset_scheduled_events_policy.yaml | Updated recordings reflecting new API version and additional read-only fields. |
| test_ppg_update.yaml | Updates API version used when fetching/updating availability sets in PPG test context. |
| _update.py | Implements new arguments, maps them into scheduledEventsPolicy, adds schema fields (allInstancesDown, scheduledEventsApiVersion, migration info, system data) and bumps API version. |
| _list.py | Updates list command to new API version and augments response schema with added scheduled events and system data fields. |
| _delete.py | Bumps delete command API version to 2025-04-01. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/availability_set/_update.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/availability_set/_update.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/availability_set/_update.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/availability_set/_update.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm availability-set updateDescription
ScheduledEventsProfile #32056
aaz: Azure/aaz#878
Testing Guide
History Notes
[Compute]
az vm availability-set update: Add new parameter--enable-all-instance-downto support setting scheduled events profile[Compute]
az vm availability-set update: Add new parameter--scheduled-events-api-versionto support setting scheduled events profileThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.