Skip to content

Comments

{CI} Fix Codegen Coverage task#32304

Closed
bebound wants to merge 1 commit intoAzure:devfrom
bebound:fix-codegen
Closed

{CI} Fix Codegen Coverage task#32304
bebound wants to merge 1 commit intoAzure:devfrom
bebound:fix-codegen

Conversation

@bebound
Copy link
Contributor

@bebound bebound commented Oct 22, 2025 •
edited
Loading

Description

azdev has update the deepdiff dependency to 8.6.1 at Azure/azure-cli-dev-tools#531

The Codegen Coverage fails with:

    from azdev.params import load_arguments
  File "/mnt/vss/_work/1/s/env/lib/python3.11/site-packages/azdev/params.py", line 14, in <module>
    from azdev.operations.command_change import diff_export_format_choices
  File "/mnt/vss/_work/1/s/env/lib/python3.11/site-packages/azdev/operations/command_change/__init__.py", line 12, in <module>
    import azure_cli_diff_tool
  File "/mnt/vss/_work/1/s/env/lib/python3.11/site-packages/azure_cli_diff_tool/__init__.py", line 15, in <module>
    from deepdiff import DeepDiff
  File "/mnt/vss/_work/1/s/env/lib/python3.11/site-packages/deepdiff/__init__.py", line 10, in <module>
    from .diff import DeepDiff
  File "/mnt/vss/_work/1/s/env/lib/python3.11/site-packages/deepdiff/diff.py", line 18, in <module>
    from deepdiff.helper import (strings, bytes_type, numbers, uuids, times, ListItemRemovedOrAdded, notpresent,
  File "/mnt/vss/_work/1/s/env/lib/python3.11/site-packages/deepdiff/helper.py", line 63, in <module>
    np_float_ = np.float_
                ^^^^^^^^^
  File "/mnt/vss/_work/1/s/env/lib/python3.11/site-packages/numpy/__init__.py", line 781, in __getattr__
    raise AttributeError(
AttributeError: `np.float_` was removed in the NumPy 2.0 release. Use `np.float64` instead.

The installed deepdiff is 6.3.3 and is not compatible with numpy 2.0. By checking the index.json in extension, confcom depends on deepdiff 6.3.3: https://github.com/Azure/azure-cli-extensions/blob/de110edc4faa6464bfa82fe8dc64f46c34ad1d77/src/confcom/setup.py#L43

Force install deepdiff 8.6.1 to fix the CI.

This PR can be reverted once confcom updates its dependency to the latest deepdiff.

Ref: https://dev.azure.com/azclitools/public/_build/results?buildId=277501&view=logs&jobId=9345cfb0-d7b9-509c-bf97-03248f55543a&j=9345cfb0-d7b9-509c-bf97-03248f55543a&t=e1a1fdd4-b888-5743-66dc-7bbee1ce278e

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 22, 2025 •
edited
Loading

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.13
️✔️acs
️✔️latest
️✔️3.12
️✔️3.13
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.13
️✔️ams
️✔️latest
️✔️3.12
️✔️3.13
️✔️apim
️✔️latest
️✔️3.12
️✔️3.13
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.13
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️aro
️✔️latest
️✔️3.12
️✔️3.13
️✔️backup
️✔️latest
️✔️3.12
️✔️3.13
️✔️batch
️✔️latest
️✔️3.12
️✔️3.13
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.13
️✔️billing
️✔️latest
️✔️3.12
️✔️3.13
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.13
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.13
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.13
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.13
️✔️config
️✔️latest
️✔️3.12
️✔️3.13
️✔️configure
️✔️latest
️✔️3.12
️✔️3.13
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.13
️✔️container
️✔️latest
️✔️3.12
️✔️3.13
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.13
️✔️core
️✔️latest
️✔️3.12
️✔️3.13
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.13
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.13
️✔️dls
️✔️latest
️✔️3.12
️✔️3.13
️✔️dms
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.13
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.13
️✔️find
️✔️latest
️✔️3.12
️✔️3.13
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.13
️✔️identity
️✔️latest
️✔️3.12
️✔️3.13
️✔️iot
️✔️latest
️✔️3.12
️✔️3.13
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.13
️✔️lab
️✔️latest
️✔️3.12
️✔️3.13
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️maps
️✔️latest
️✔️3.12
️✔️3.13
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.13
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.13
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.13
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.13
️✔️network
️✔️latest
️✔️3.12
️✔️3.13
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.13
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.13
️✔️profile
️✔️latest
️✔️3.12
️✔️3.13
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.13
️✔️redis
️✔️latest
️✔️3.12
️✔️3.13
️✔️relay
️✔️latest
️✔️3.12
️✔️3.13
️✔️resource
️✔️latest
️✔️3.12
️✔️3.13
️✔️role
️✔️latest
️✔️3.12
️✔️3.13
️✔️search
️✔️latest
️✔️3.12
️✔️3.13
️✔️security
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.13
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.13
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.13
️✔️sql
️✔️latest
️✔️3.12
️✔️3.13
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.13
️✔️storage
️✔️latest
️✔️3.12
️✔️3.13
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.13
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.13
️✔️util
️✔️latest
️✔️3.12
️✔️3.13
️✔️vm
️✔️latest
️✔️3.12
️✔️3.13

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 22, 2025

Hi @bebound,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 22, 2025 •
edited
Loading

️✔️AzureCLI-BreakingChangeTest
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 22, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@bebound bebound marked this pull request as ready for review October 22, 2025 06:21
Copilot AI review requested due to automatic review settings October 22, 2025 06:21
Copilot AI reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a CI failure in the Codegen Coverage task caused by an incompatibility between deepdiff 6.3.3 (pinned by the confcom extension) and numpy 2.0. The fix temporarily force-installs deepdiff 8.6.1 after extension setup to ensure compatibility with numpy 2.0.

Key Changes:

  • Added a pip install command to force deepdiff 8.6.1 installation after azdev setup completes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot CI CI labels Oct 22, 2025
@jiasli
Copy link
Member

jiasli commented Oct 22, 2025

This PR can be reverted once confcom updates its dependency to the latest deepdiff.

Is there an issue created for confcom?

@bebound bebound mentioned this pull request Oct 22, 2025
Closed
@bebound
Copy link
Contributor Author

bebound commented Oct 22, 2025 •
edited
Loading

This PR can be reverted once confcom updates its dependency to the latest deepdiff.

Is there an issue created for confcom?

I've told @DomAyre to bump deepdiff in confcom

Issue: Azure/azure-cli-extensions#9323

RP to bump deepdiff in confcom: Azure/azure-cli-extensions#9318

@bebound
Copy link
Contributor Author

bebound commented Oct 28, 2025

Close as Azure/azure-cli-extensions#9318 is merged

@bebound bebound closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jiasli jiasli jiasli approved these changes

@wangzelin007 wangzelin007 wangzelin007 approved these changes

@yonzhan yonzhan Awaiting requested review from yonzhan

@kairu-ms kairu-ms Awaiting requested review from kairu-ms

@jsntcy jsntcy Awaiting requested review from jsntcy

@Pan-Qi Pan-Qi Awaiting requested review from Pan-Qi

Assignees

@jiasli jiasli

@wangzelin007 wangzelin007

Labels

Auto-Assign Auto assign by bot CI CI Installation

Projects

None yet

Milestone

November 2025 (2025-11-18)❗ Breaking ...

Development

Successfully merging this pull request may close these issues.

4 participants

@bebound @yonzhan @jiasli @wangzelin007