Conversation
️✔️AzureCLI-FullTest
|
|
Hi @cxznmhdcxz, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network application-gateway http-settings create | cmd network application-gateway http-settings create added parameter dedicated_backend_connection |
||
| network application-gateway http-settings create | cmd network application-gateway http-settings create added parameter sni_name |
||
| network application-gateway http-settings create | cmd network application-gateway http-settings create added parameter validate_cert_chain_and_expiry |
||
| network application-gateway http-settings create | cmd network application-gateway http-settings create added parameter validate_sni |
||
| network application-gateway http-settings update | cmd network application-gateway http-settings update added parameter dedicated_backend_connection |
||
| network application-gateway http-settings update | cmd network application-gateway http-settings update added parameter sni_name |
||
| network application-gateway http-settings update | cmd network application-gateway http-settings update added parameter validate_cert_chain_and_expiry |
||
| network application-gateway http-settings update | cmd network application-gateway http-settings update added parameter validate_sni |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for new SSL/TLS validation parameters to Azure Application Gateway HTTP settings, specifically adding support for certificate validation options introduced in API version 2024-10-01.
Key Changes:
- Updated Application Gateway HTTP settings commands to support certificate validation parameters (
validateCertChainAndExpiry,validateSNI) - Added SNI configuration options (
sniName,dedicatedBackendConnection) for HTTP settings - Updated API version from 2023-11-01 to 2024-10-01 across HTTP settings commands
- Added test coverage for the new validation parameters
- Updated test recordings to reflect API version changes
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_network_commands.py | Added test case for new certificate validation parameters in HTTP settings |
| _create.py | Added new parameters with defaults for certificate validation (validateCertChainAndExpiry, validateSNI) |
| _update.py | Added new parameters for updating certificate validation settings |
| _show.py, _list.py, _wait.py, _delete.py | Updated API version and schema to support new properties |
| test recordings (*.yaml) | Updated to reflect new API version 2024-10-01 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../cli/command_modules/network/aaz/latest/network/application_gateway/http_settings/_update.py
Show resolved
Hide resolved
.../cli/command_modules/network/aaz/latest/network/application_gateway/http_settings/_create.py
Show resolved
Hide resolved
az network application-gateway http-settings create: Support parameters dedicatedBackendConnection, validateCertChainAndExpiry, validateSNI, and sniNameaz network application-gateway http-settings: Support dedicated backend connection and certificate validation
Related command
az network application-gateway http-settingscommand groupDescription
resolve #32075
aaz Azure/aaz#887
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.