Conversation
nirnaymsft
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @nirnaymsft, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for local DNS profile configuration in AKS node pools, including both valid and invalid configuration scenarios. The changes include removing extraneous blank lines from existing test files and adding new test files for local DNS profile functionality.
Key Changes
- Added new test file
test_localdns_profile.pywith unit tests for local DNS profile parsing and validation - Added extensive integration tests in
test_aks_commands.pycovering various local DNS configuration scenarios (valid/invalid modes, DNS overrides, updates) - Added test data files for different local DNS configuration scenarios
- Removed trailing blank lines from test files for consistency
Reviewed Changes
Copilot reviewed 34 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_managed_cluster_decorator.py | Removed extraneous blank lines |
| test_localdns_profile.py | New test file with unit tests for local DNS profile configuration parsing |
| test_aks_commands.py | Added 1400+ lines of integration tests for local DNS profile functionality |
| test_agentpool_decorator.py | Removed blank lines and added unit tests for local DNS profile update methods |
| test_aks_nodepool_update_localdns_required_to_localdnsconfig_with_extra_property_in_dnsOverrides.yaml | New test recording file |
| required_mode_with_valid_vnetdns.json | Test data for valid vnet DNS override configuration |
| required_mode_with_valid_kubedns.json | Test data for valid kube DNS override configuration |
| required_mode_partial_invalid.json | Test data for invalid partial DNS override configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FumingZhang
reviewed
Nov 6, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_agentpool_decorator.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
nirnaymsft
changed the title
saewoni
reviewed
Nov 6, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
saewoni
reviewed
Nov 6, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
saewoni
reviewed
Nov 6, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
- Clean up test files and recordings - Fix whitespace and formatting in source files - Remove unused test data files and recordings - Update test files to meet style requirements
saewoni
reviewed
Nov 6, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_localdns_profile.py
Show resolved
Hide resolved
saewoni
reviewed
Nov 6, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Show resolved
Hide resolved
saewoni
reviewed
Nov 6, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Show resolved
Hide resolved
saewoni
reviewed
Nov 6, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Show resolved
Hide resolved
saewoni
reviewed
Nov 6, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
nirnaymsft
changed the title
saewoni
approved these changes
Nov 7, 2025
Collaborator
|
Please fix CI issues |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32392 in repo Azure/azure-cli |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Nov 8, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
Collaborator
|
Please fix CI issues |
nirnaymsft
changed the title
Contributor
Author
@yonzhan Fixed the PR Title. Can you please retrigger the check. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
nirnaymsft
changed the title
az aks nodepool
Contributor
Author
|
@FumingZhang, @yonzhan Can you trigger "Azure.azure-cli (Check the Format of Pull Request Title and Content)" again. |
Member
|
please follow the guidance to rename your PR title to something like |
nirnaymsft
changed the title
az aks nodepoolaz aks nodepool add/update: Add option --localdns-config to config local dns profile for the nodepool
Contributor
Author
|
@FumingZhang Changed. Thank you. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
approved these changes
Nov 9, 2025
yanzhudd
changed the title
az aks nodepool add/update: Add option --localdns-config to config local dns profile for the nodepoolaz aks nodepool add/update: Add parameter --localdns-config to config local dns profile for the nodepool
yanzhudd
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds option
--localdns-configto config local dns profile for the nodepool ataz aks nodepool add/updatecliChanges
Testing