Conversation
️✔️AzureCLI-FullTest
|
|
Hi @calvinhzy, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
calvinhzy
requested review from
evelyn-ys,
jsntcy and
zhoxing-ms
as code owners
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances file listing functionality for Azure Storage file shares by ensuring that extended metadata (timestamps, Etag, Attributes, PermissionKey) is included for SMB shares while maintaining NFS share compatibility.
Key Changes:
- Added test assertion to verify
lastAccessTimeis present in file list output for SMB shares - Refactored conditional logic in
list_share_filesto use a more maintainable if-else structure - Updated test recordings to reflect CLI version 2.79.0 and include additional file metadata in responses
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test_storage_file_scenarios.py | Added test to verify lastAccessTime field is returned when listing files on SMB shares |
| file.py | Refactored protocol check logic from if-elif to if-else structure for better clarity and to ensure SMB shares include extended metadata |
| test_storage_file_share_nfs_scenario.yaml | Updated test recording with new CLI version and timestamps |
| test_storage_file_main_scenario.yaml | Updated test recording with new CLI version, timestamps, and extended file metadata fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_file_scenarios.py
Outdated
Show resolved
Hide resolved
evelyn-ys
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Fix #32399 , should show additional info without manually setting share protocol to be nfs or smb
Testing Guide
History Notes
[Storage] Fix #32399:
az storage file list: Fix not showing additional info when listing files without set protocolThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.