{CognitiveService} Fix block issues for release tasks#32411
Closed
{CognitiveService} Fix block issues for release tasks#32411
Conversation
kairu-ms
requested review from
bebound,
calvinhzy and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
teresaritorto
previously approved these changes
Nov 11, 2025
evelyn-ys
previously approved these changes
Nov 11, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes block issues for CognitiveServices release tasks by reorganizing test data files and updating test file references. The primary purpose is to move connection test data from an incorrect directory structure to the proper location.
- Changed the
INPUT_DATA_PATHfrom'connections'to'data'subdirectory in test files - Added comprehensive YAML test data files for various connection types (Azure OpenAI, AI Services, Content Safety, Speech Services, Search, blob storage, databases, etc.)
- Updated CredScan suppressions to allow test files containing dummy passwords
Reviewed Changes
Copilot reviewed 3 out of 42 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test_project_connections.py |
Updated INPUT_DATA_PATH to point to 'data' subdirectory instead of 'connections' |
test_account_connections.py |
Updated INPUT_DATA_PATH references (2 occurrences) to point to 'data' subdirectory |
input_data/data/*.yaml |
Added 45+ YAML test data files for various connection types including Azure services, databases, and third-party integrations |
CredScanSuppressions.json |
Added suppressions for 7 test files containing dummy passwords for testing purposes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| class CognitiveServicesProjectConnectionsTests(ScenarioTest): | ||
|
|
||
| INPUT_DATA_PATH=os.path.join(TEST_DIR, 'input_data', 'connections') | ||
| INPUT_DATA_PATH=os.path.join(TEST_DIR, 'input_data', 'data') |
There was a problem hiding this comment.
The assignment operator should have spaces around it for consistency with PEP 8 style guidelines and to match the identical attribute definition in test_account_connections.py (lines 15, 27). Consider also adding the type annotation : str for consistency.
Suggested change:
INPUT_DATA_PATH: str = os.path.join(TEST_DIR, 'input_data', 'data')
wangzelin007
previously approved these changes
Nov 11, 2025
kairu-ms
dismissed stale reviews from wangzelin007, evelyn-ys, and teresaritorto
via
415dbce
kairu-ms
force-pushed
the
fix-cognitive-service-ci-issues
branch
from
a5b0f33 to
415dbce
Compare
naga-nandyala
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.