{CognitiveService} Fix block issues for release tasks #32412
Merged
naga-nandyala merged 2 commits intodevfrom Nov 11, 2025
Merged
{CognitiveService} Fix block issues for release tasks #32412naga-nandyala merged 2 commits intodevfrom
naga-nandyala merged 2 commits intodevfrom
Conversation
naga-nandyala
requested review from
bebound,
calvinhzy,
jiasli,
kairu-ms and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
kairu-ms
previously approved these changes
Nov 11, 2025
kairu-ms
reviewed
Nov 11, 2025
| "_justification": "[RDBMS] False positive" | ||
| }, | ||
| { | ||
| "file": [ |
Contributor
There was a problem hiding this comment.
Please do some modifications, such as change the order of files
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes blocking issues for release tasks in the Cognitive Services module by updating file path references in test files and adding credential scan suppressions.
Key Changes:
- Updated test data path references from 'input_data/connections' to 'data' in test files
- Added credential scan suppressions for test YAML files containing authentication credentials
Reviewed Changes
Copilot reviewed 3 out of 42 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test_project_connections.py | Updated INPUT_DATA_PATH to use simplified 'data' directory path |
| test_account_connections.py | Updated INPUT_DATA_PATH references (2 occurrences) to use simplified 'data' directory path |
| CredScanSuppressions.json | Added suppressions for test data files containing mock credentials |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kairu-ms
approved these changes
Nov 11, 2025
wangzelin007
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.