Conversation
joslinmicrosoft
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @joslinmicrosoft, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| appservice list-locations | cmd appservice list-locations added parameter managed_instance_enabled |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for filtering App Service locations by Managed Instance availability through a new --managed-instance-enabled flag for the az appservice list-locations command. The implementation validates that only PREMIUMV4 and PREMIUMMV4 SKU tiers are supported for Managed Instances and uses the newer API version 2025-03-01 to query regions that support custom mode workers.
Key Changes:
- Added
--managed-instance-enabledparameter (marked as preview) to enable filtering for Managed Instance-compatible regions - Implemented SKU tier validation to ensure only PREMIUMV4 and PREMIUMMV4 tiers are accepted for Managed Instances
- Introduced a new AAZ command wrapper (
AppServiceListLocations) utilizing API version 2025-03-01 for managed instance region queries
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/appservice/_params.py |
Added --managed-instance-enabled parameter definition marked as preview |
src/azure-cli/azure/cli/command_modules/appservice/utils.py |
Added is_sku_tier_enabled_for_managed_instance() helper function to validate SKU tier eligibility |
src/azure-cli/azure/cli/command_modules/appservice/custom.py |
Modified list_locations() to handle managed instance filtering and added _list_managed_instance_locations() helper function |
src/azure-cli/azure/cli/command_modules/appservice/aaz/latest/appservice/_list_locations.py |
Auto-generated AAZ command class for calling the 2025-03-01 API version with custom mode workers support |
src/azure-cli/azure/cli/command_modules/appservice/aaz/latest/appservice/__init__.py |
Added import for the new ListLocations AAZ command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/appservice/aaz/latest/appservice/_list_locations.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/appservice/aaz/latest/appservice/_list_locations.py
Outdated
Show resolved
Hide resolved
…appservice/_list_locations.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
Contributor
|
could you please add some tests for this change |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
please submit a PR for the change of aaz repo as well |
yanzhudd
changed the title
az appservice list-locations: Add --managed-instance-enabled flag for Managed Instancesaz appservice list-locations: Add --managed-instance-enabled flag for managed instances
Member
Author
@yanzhudd PR has been submitted with the change here: Azure/aaz#901 |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Dec 3, 2025
yanzhudd
changed the title
az appservice list-locations: Add --managed-instance-enabled flag for managed instancesaz appservice list-locations: Add --managed-instance-enabled parameter for managed instances
huiii99
pushed a commit
to huiii99/azure-cli
that referenced
this pull request
Dec 4, 2025
…-enabled` parameter for managed instances (Azure#32444)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az appservice list-locationsDescription
We recently announced support for Managed Instance on Azure App Service, which is a new type of App Service Plan. We are adding the
--managed-instance-enabledflag to theaz appservice list-locationsso customers can determine which regions support Managed Instances.Testing Guide
az appservice list-locations --managed-instance-enabled --sku P1V4az appservice list-locations --managed-instance-enabled --sku P2V4az appservice list-locations --managed-instance-enabled --sku P1mV4These three all return the expected list of regions for Managed Instances, with the supported SKU.
az appservice list-locations --managed-instance-enabled --sku S1This returns an empty list as expected as S1 is not a supported SKU
az appservice list-locations --hyperv-workers-enabled --sku P1V3az appservice list-locations --linux-workers-enabled --sku S1Spot check that existing flags still give the correct list of regions
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.