Conversation
Greedygre
requested review from
Juliehzl,
howang-ms,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Greedygre, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env create | cmd containerapp env create added parameter infrastructure_resource_group |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the --infrastructure-resource-group parameter to the az containerapp env create command, migrating this functionality from the containerapp extension to the Core CLI. The parameter allows users to specify a custom resource group name for infrastructure resources when creating a container app environment.
- Added parameter definition with
-ishort option for infrastructure resource group - Implemented validation requiring both subnet resource ID and workload profiles to be enabled
- Added property assignment logic in the environment decorator
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| _params.py | Adds the --infrastructure-resource-group/-i parameter definition with help text |
| custom.py | Adds the infrastructure_resource_group parameter to the create_managed_environment function signature |
| containerapp_env_decorator.py | Implements getter, validation logic, and property assignment for the infrastructure resource group |
| test_containerapp_env_commands.py | Adds E2E test for the infrastructure resource group feature |
| custom_preparers.py | Introduces SubnetPreparer for test setup |
| common.py | Adds STAGE_LOCATION constant for test configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/containerapp/tests/latest/custom_preparers.py
Show resolved
Hide resolved
BlackRider97
approved these changes
Nov 25, 2025
ShichaoQiu
approved these changes
Nov 25, 2025
Collaborator
|
Please fix CI issues |
bowen5
approved these changes
Nov 25, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
az containerapp env create: Support --infrastructure-resource-groupaz containerapp env create: Add parameter --infrastructure-resource-group to support specifying name for resource group that will contain infrastructure resources
yanzhudd
approved these changes
Nov 27, 2025
yanzhudd
changed the title
az containerapp env create: Add parameter --infrastructure-resource-group to support specifying name for resource group that will contain infrastructure resourcesaz containerapp env create: Add parameter --infrastructure-resource-group to support specifying name for resource group that will contain infrastructure resources
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move property
--infrastructure-resource-groupin containerapp extension to Core CLIRelated command
az containerapp env createDescription
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.