Conversation
…a 25 - Remove hardcoded Java version lists that were missing Java 25 - Add dynamic parsing of Java versions from API's runtimes array - Add _get_java_versions_from_minor_versions() for Linux Java SE containers - Add _get_java_versions_from_windows_container() for Windows containers - Add _get_java_runtimes_from_container_settings() for Linux container runtimes - Add deduplication to prevent duplicate runtime entries (e.g., JBOSSEAP) - Future-proof: new Java versions will automatically appear without code changes
seligj95
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the az webapp list-runtimes command to dynamically discover Java versions from the API instead of using hardcoded lists, ensuring Java 25 and future versions appear automatically.
Key Changes:
- Added three new helper methods to dynamically extract Java versions from API data structures
- Implemented runtime deduplication for Linux to prevent duplicate entries (e.g., JBOSSEAP)
- Replaced hardcoded Java version lists ("21", "17", "11", "1.8") with dynamic parsing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add _java_version_sort_key() helper to handle various version formats - Handles '1.8', '1.x', 'X.Y' (e.g., '11.0'), and plain integers - Prevents ValueError when version strings can't be directly converted to int
- Add explanatory comment for Linux-only deduplication logic - Add debug logging when no Java versions found in Windows container settings
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Use regex pattern to extract version from java*Runtime keys instead of magic string slicing - Use min() instead of ternary for limiting list length
3 tasks
Contributor
Author
|
@yonzhan - is there a reason this was moved out of the next milestone? i've had this done for over a month now and we have some customers waiting for it so was hoping it could get reviewed soon |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp list-runtimes
Description
Fix list-runtimes to dynamically discover Java versions including Java 25
Testing Guide
az webapp list-runtimesshould now show Java 25History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.