Conversation
william051200
requested review from
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive test case for the computedDisabledRules property in Application Gateway WAF policies. The test validates that disabled rules are correctly tracked in the computedDisabledRules list across add, update, list, and remove operations on WAF policy managed rule sets.
Key Changes:
- Adds new test
test_network_app_gateway_waf_policy_compute_disabled_rulecovering the full lifecycle of disabled rule tracking - Verifies that rules are added to
computedDisabledRuleswhen disabled and removed when enabled - Includes test recording file for the new test case
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test_network_commands.py | Adds comprehensive test case validating computedDisabledRules behavior for WAF policy rule sets across add/update/list/remove operations |
| test_network_app_gateway_waf_policy_compute_disabled_rule.yaml | Test recording file capturing API interactions for the new test case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
necusjz
changed the title
az network application-gateway waf-policy managed-rule rule-set: Support disabled rules by default
necusjz
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network application-gateway waf-policy managed-rule rule-set addaz network application-gateway waf-policy managed-rule rule-set updateaz network application-gateway waf-policy managed-rule rule-set listaz network application-gateway waf-policy managed-rule rule-set removeDescription
Resolve #31646
Testing Guide
To make sure the new added rule is set as
Disabledand being added tocomputedDisabledRuleslist.az network application-gateway waf-policy managed-rule rule-set addTo make sure the rule is being removed from
computedDisabledRuleslist when it is updated toEnabled.To make sure the rule is being added to
computedDisabledRuleslist when it is updated toDisabled.az network application-gateway waf-policy managed-rule rule-set updateTo make sure
computedDisabledRuleslist is being shown.az network application-gateway waf-policy managed-rule rule-set listTo make sure rule is being removed from
computedDisabledRuleslist.az network application-gateway waf-policy managed-rule rule-set removeHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.