Conversation
…etion of…" This reverts commit 48fc08b.
honghr
requested review from
evelyn-ys,
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
yonzhan and
zhoxing-ms
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reverts a previous feature that added support for deleting on-demand backups in Azure MySQL flexible servers, rolling back to an earlier version of the MySQL management SDK.
Key Changes:
- Downgrade
azure-mgmt-mysqlflexibleserversfrom version1.1.0b1to1.0.0b3across all platform requirement files - Remove the
backup deletecommand, its parameters, and help documentation from the MySQL command module - Revert test changes including test configurations, expected values, and test recordings
Reviewed changes
Copilot reviewed 10 out of 39 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/azure-cli/setup.py |
Downgrade MySQL flexible servers SDK from 1.1.0b1 to 1.0.0b3 |
src/azure-cli/requirements.py3.windows.txt |
Update Windows requirements to use older SDK version |
src/azure-cli/requirements.py3.Linux.txt |
Update Linux requirements to use older SDK version |
src/azure-cli/requirements.py3.Darwin.txt |
Update macOS requirements to use older SDK version |
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_private_endpoint_commands.py |
Revert test changes with a critical typo introduced (flexible_sever_id instead of flexible_server_id) |
src/azure-cli/azure/cli/command_modules/mysql/tests/latest/test_mysql_scenario.py |
Revert test code changes, re-enable export test, and update test expectations |
src/azure-cli/azure/cli/command_modules/mysql/tests/latest/recordings/test_mysql_flexible_server_maintenance_mgmt.yaml |
Update test recordings with earlier dates matching the revert |
src/azure-cli/azure/cli/command_modules/mysql/commands.py |
Remove backup delete command registration |
src/azure-cli/azure/cli/command_modules/mysql/_params.py |
Remove backup delete parameters and revert backup show parameter configuration |
src/azure-cli/azure/cli/command_modules/mysql/_help.py |
Remove backup delete command help documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_private_endpoint_commands.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_private_endpoint_commands.py
Show resolved
Hide resolved
evelyn-ys
approved these changes
Dec 10, 2025
evelyn-ys
changed the title
az mysql flexible-server backup delete: Support deletion of on-demand backup"az mysql flexible-server backup delete: Support deletion of on-demand backup"
evelyn-ys
changed the title
az mysql flexible-server backup delete: Support deletion of on-demand backup"az mysql flexible-server backup delete: Support deletion of on-demand backup
necusjz
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #32498