Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the az postgres flexible-server update command where updating a server to enable high availability with a standby zone was incorrectly failing with an InvalidParameterValue error.
Key Changes:
- Fixed logical operator in high availability validator from OR to AND to properly validate when standby zones can be specified
- Added
availability_zoneparameter to theServerForPatchobject to ensure the primary zone is included when updating HA settings
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/rdbms/validators.py | Corrected validation logic to allow setting standby zone when either high availability mode OR zonal resiliency is enabled (changed from requiring both) |
| src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py | Added availability_zone to ServerForPatch parameters to satisfy API requirements when updating high availability with standby zone |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattboentoro
approved these changes
Dec 19, 2025
Member
Author
|
@evelyn-ys Please trigger checks and review |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
@evelyn-ys please merge |
evelyn-ys
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server updateDescription
az cli is returning invalid parameter when there is no invalid parameter.
(InvalidParameterValue) Invalid value given for parameter StandbyAvailabilityZone,availabilityZone. Specify a valid parameter value.
Code: InvalidParameterValue
Message: Invalid value given for parameter StandbyAvailabilityZone,availabilityZone. Specify a valid parameter value.
Testing Guide
'postgres' 'flexible-server' 'update' '-g' 'rg' '-n' 'nasc-ha-930' '--zonal-resiliency' 'Enabled' '--standby-zone' '2'
{
"availabilityZone": "1",
...
"fullyQualifiedDomainName": "nasc-ha-930.postgres.database.azure.com",
"highAvailability": {
"mode": "ZoneRedundant",
"standbyAvailabilityZone": "2",
"state": "Healthy"
},
History Notes
[RDBMS]
az postgres flexible-server update: Fix bug for using argument--standby-zonewhen enabling high availability